From e891f29b95bb45ad3ce642b4387a977fae547939 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Steinbrink?= Date: Mon, 13 Apr 2015 13:05:19 +0200 Subject: [PATCH] Fix ICE when returning a variable whose declaration is unreachable Fixes #24353 --- src/librustc_trans/trans/controlflow.rs | 4 +++- src/test/run-pass/issue24353.rs | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 src/test/run-pass/issue24353.rs diff --git a/src/librustc_trans/trans/controlflow.rs b/src/librustc_trans/trans/controlflow.rs index f544efe7401c4..8cecc39ec3900 100644 --- a/src/librustc_trans/trans/controlflow.rs +++ b/src/librustc_trans/trans/controlflow.rs @@ -131,7 +131,9 @@ pub fn trans_block<'blk, 'tcx>(bcx: Block<'blk, 'tcx>, match b.expr { Some(ref e) => { - bcx = expr::trans_into(bcx, &**e, dest); + if !bcx.unreachable.get() { + bcx = expr::trans_into(bcx, &**e, dest); + } } None => { assert!(dest == expr::Ignore || bcx.unreachable.get()); diff --git a/src/test/run-pass/issue24353.rs b/src/test/run-pass/issue24353.rs new file mode 100644 index 0000000000000..7a41a0139273f --- /dev/null +++ b/src/test/run-pass/issue24353.rs @@ -0,0 +1,16 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +fn main() { + return (); + + let x = (); + x +}