diff --git a/src/librustc/hir/intravisit.rs b/src/librustc/hir/intravisit.rs index b5a6ba3555dd1..dcdba57fc719d 100644 --- a/src/librustc/hir/intravisit.rs +++ b/src/librustc/hir/intravisit.rs @@ -95,14 +95,13 @@ pub trait Visitor<'v> : Sized { /////////////////////////////////////////////////////////////////////////// // Nested items. - /// The default versions of the `visit_nested_XXX` routines invoke - /// this method to get a map to use; if they get back `None`, they - /// just skip nested things. Otherwise, they will lookup the - /// nested item-like things in the map and visit it. So the best - /// way to implement a nested visitor is to override this method - /// to return a `Map`; one advantage of this is that if we add - /// more types of nested things in the future, they will - /// automatically work. + /// The default versions of the `visit_nested_XXX` routines invoke this + /// method to get a map to use; if they get back `None`, they just skip + /// nested things. Otherwise, they will lookup the nested thing in the map + /// and visit it depending on what `nested_visit_mode` returns. So the best + /// way to implement a nested visitor is to override this method to return a + /// `Map`; one advantage of this is that if we add more types of nested + /// things in the future, they will automatically work. /// /// **If for some reason you want the nested behavior, but don't /// have a `Map` are your disposal:** then you should override the @@ -110,8 +109,12 @@ pub trait Visitor<'v> : Sized { /// `panic!()`. This way, if a new `visit_nested_XXX` variant is /// added in the future, we will see the panic in your code and /// fix it appropriately. - fn nested_visit_map(&mut self) -> Option<(&Map<'v>, NestedVisitMode)> { - None + fn nested_visit_map(&mut self) -> Option<&Map<'v>>; + + /// Specifies what things nested things this visitor wants to visit. By + /// default, bodies will be visited, but not nested items. + fn nested_visit_mode(&mut self) -> NestedVisitMode { + NestedVisitMode::OnlyBodies } /// Invoked when a nested item is encountered. By default does @@ -300,16 +303,15 @@ pub trait Visitor<'v> : Sized { } fn map_for_body<'v, V: Visitor<'v>>(visitor: &mut V) -> Option<&Map<'v>> { - visitor.nested_visit_map().map(|(map, _mode)| map) + visitor.nested_visit_map() } fn map_for_item<'v, V: Visitor<'v>>(visitor: &mut V) -> Option<&Map<'v>> { - visitor.nested_visit_map().and_then(|(map, mode)| { - match mode { - NestedVisitMode::OnlyBodies => None, - NestedVisitMode::All => Some(map) - } - }) + match visitor.nested_visit_mode() { + NestedVisitMode::OnlyBodies => None, + NestedVisitMode::All => Some(visitor.nested_visit_map() + .expect("NestedVisitMode::All without nested_visit_map")) + } } pub fn walk_opt_name<'v, V: Visitor<'v>>(visitor: &mut V, span: Span, opt_name: Option) { @@ -1059,8 +1061,8 @@ impl<'a, 'ast> IdRangeComputingVisitor<'a, 'ast> { } impl<'a, 'ast> Visitor<'ast> for IdRangeComputingVisitor<'a, 'ast> { - fn nested_visit_map(&mut self) -> Option<(&Map<'ast>, NestedVisitMode)> { - Some((&self.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&Map<'ast>> { + Some(&self.map) } fn visit_id(&mut self, id: NodeId) { diff --git a/src/librustc/hir/map/collector.rs b/src/librustc/hir/map/collector.rs index 524a112561939..2cfb35affc7bf 100644 --- a/src/librustc/hir/map/collector.rs +++ b/src/librustc/hir/map/collector.rs @@ -10,7 +10,7 @@ use super::*; -use hir::intravisit::{Visitor, NestedVisitMode}; +use hir::intravisit::Visitor; use hir::def_id::DefId; use middle::cstore::InlinedItem; use std::iter::repeat; @@ -91,7 +91,7 @@ impl<'ast> Visitor<'ast> for NodeCollector<'ast> { /// deep walking so that we walk nested items in the context of /// their outer items. - fn nested_visit_map(&mut self) -> Option<(&map::Map<'ast>, NestedVisitMode)> { + fn nested_visit_map(&mut self) -> Option<&map::Map<'ast>> { panic!("visit_nested_xxx must be manually implemented in this visitor") } diff --git a/src/librustc/hir/map/def_collector.rs b/src/librustc/hir/map/def_collector.rs index a6d7c79e34646..30445ffe73e28 100644 --- a/src/librustc/hir/map/def_collector.rs +++ b/src/librustc/hir/map/def_collector.rs @@ -327,6 +327,10 @@ impl<'a> visit::Visitor for DefCollector<'a> { // We walk the HIR rather than the AST when reading items from metadata. impl<'ast> intravisit::Visitor<'ast> for DefCollector<'ast> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'ast>> { + None + } + fn visit_body(&mut self, id: hir::ExprId) { if let Some(krate) = self.hir_crate { self.visit_expr(krate.expr(id)); diff --git a/src/librustc/lint/context.rs b/src/librustc/lint/context.rs index 799c7e0cc84bc..0ec2e6641b943 100644 --- a/src/librustc/lint/context.rs +++ b/src/librustc/lint/context.rs @@ -791,8 +791,12 @@ impl<'a, 'tcx> hir_visit::Visitor<'tcx> for LateContext<'a, 'tcx> { /// Because lints are scoped lexically, we want to walk nested /// items in the context of the outer item, so enable /// deep-walking. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, hir_visit::NestedVisitMode)> { - Some((&self.tcx.map, hir_visit::NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) + } + + fn nested_visit_mode(&mut self) -> hir_visit::NestedVisitMode { + hir_visit::NestedVisitMode::All } fn visit_item(&mut self, it: &'tcx hir::Item) { @@ -1109,8 +1113,8 @@ struct IdVisitor<'a, 'b: 'a, 'tcx: 'a+'b> { // Output any lints that were previously added to the session. impl<'a, 'b, 'tcx> hir_visit::Visitor<'tcx> for IdVisitor<'a, 'b, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, hir_visit::NestedVisitMode)> { - Some((&self.cx.tcx.map, hir_visit::NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.cx.tcx.map) } fn visit_id(&mut self, id: ast::NodeId) { diff --git a/src/librustc/middle/dataflow.rs b/src/librustc/middle/dataflow.rs index 1ec3d0db8e0aa..5fc7d43f48d09 100644 --- a/src/librustc/middle/dataflow.rs +++ b/src/librustc/middle/dataflow.rs @@ -193,6 +193,8 @@ fn build_nodeid_to_index(decl: Option<&hir::FnDecl>, let mut formals = Formals { entry: entry, index: index }; intravisit::walk_fn_decl(&mut formals, decl); impl<'a, 'v> intravisit::Visitor<'v> for Formals<'a> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_pat(&mut self, p: &hir::Pat) { self.index.entry(p.id).or_insert(vec![]).push(self.entry); intravisit::walk_pat(self, p) diff --git a/src/librustc/middle/dead.rs b/src/librustc/middle/dead.rs index 575ac9773a7da..f96bfb4718eda 100644 --- a/src/librustc/middle/dead.rs +++ b/src/librustc/middle/dead.rs @@ -221,8 +221,8 @@ impl<'a, 'tcx> MarkSymbolVisitor<'a, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for MarkSymbolVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_variant_data(&mut self, def: &'tcx hir::VariantData, _: ast::Name, @@ -510,10 +510,12 @@ impl<'a, 'tcx> Visitor<'tcx> for DeadVisitor<'a, 'tcx> { /// on inner functions when the outer function is already getting /// an error. We could do this also by checking the parents, but /// this is how the code is setup and it seems harmless enough. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::All } + fn visit_item(&mut self, item: &'tcx hir::Item) { if self.should_warn_about_item(item) { self.warn_dead_code( diff --git a/src/librustc/middle/effect.rs b/src/librustc/middle/effect.rs index 57735b91ac5d6..8b0432df2f019 100644 --- a/src/librustc/middle/effect.rs +++ b/src/librustc/middle/effect.rs @@ -21,7 +21,7 @@ use syntax::ast; use syntax_pos::Span; use hir::{self, PatKind}; use hir::def::Def; -use hir::intravisit::{self, FnKind, Visitor, NestedVisitMode}; +use hir::intravisit::{self, FnKind, Visitor}; #[derive(Copy, Clone)] struct UnsafeContext { @@ -93,8 +93,8 @@ impl<'a, 'tcx> EffectCheckVisitor<'a, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for EffectCheckVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_fn(&mut self, fn_kind: FnKind<'tcx>, fn_decl: &'tcx hir::FnDecl, diff --git a/src/librustc/middle/intrinsicck.rs b/src/librustc/middle/intrinsicck.rs index 5673ec05cf940..49ada60c57675 100644 --- a/src/librustc/middle/intrinsicck.rs +++ b/src/librustc/middle/intrinsicck.rs @@ -19,7 +19,7 @@ use ty::layout::{LayoutError, Pointer, SizeSkeleton}; use syntax::abi::Abi::RustIntrinsic; use syntax::ast; use syntax_pos::Span; -use hir::intravisit::{self, Visitor, FnKind, NestedVisitMode}; +use hir::intravisit::{self, Visitor, FnKind}; use hir; pub fn check_crate<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>) { @@ -117,8 +117,8 @@ impl<'a, 'gcx, 'tcx> ExprVisitor<'a, 'gcx, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for ItemVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } // const, static and N in [T; N]. @@ -163,8 +163,8 @@ impl<'a, 'tcx> Visitor<'tcx> for ItemVisitor<'a, 'tcx> { } impl<'a, 'gcx, 'tcx> Visitor<'gcx> for ExprVisitor<'a, 'gcx, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'gcx>, NestedVisitMode)> { - Some((&self.infcx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'gcx>> { + Some(&self.infcx.tcx.map) } fn visit_expr(&mut self, expr: &'gcx hir::Expr) { diff --git a/src/librustc/middle/liveness.rs b/src/librustc/middle/liveness.rs index ca28f1dae291a..94f880f9fdff6 100644 --- a/src/librustc/middle/liveness.rs +++ b/src/librustc/middle/liveness.rs @@ -128,7 +128,7 @@ use syntax_pos::Span; use hir::Expr; use hir; use hir::print::{expr_to_string, block_to_string}; -use hir::intravisit::{self, Visitor, FnKind, NestedVisitMode}; +use hir::intravisit::{self, Visitor, FnKind}; /// For use with `propagate_through_loop`. enum LoopKind<'a> { @@ -183,8 +183,8 @@ fn live_node_kind_to_string(lnk: LiveNodeKind, tcx: TyCtxt) -> String { } impl<'a, 'tcx> Visitor<'tcx> for IrMaps<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_fn(&mut self, fk: FnKind<'tcx>, fd: &'tcx hir::FnDecl, b: hir::ExprId, s: Span, id: NodeId) { @@ -352,8 +352,8 @@ impl<'a, 'tcx> IrMaps<'a, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for Liveness<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.ir.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.ir.tcx.map) } fn visit_fn(&mut self, _: FnKind<'tcx>, _: &'tcx hir::FnDecl, _: hir::ExprId, _: Span, _: NodeId) { diff --git a/src/librustc/middle/reachable.rs b/src/librustc/middle/reachable.rs index f8a1b109d9dbd..31731adc08793 100644 --- a/src/librustc/middle/reachable.rs +++ b/src/librustc/middle/reachable.rs @@ -28,7 +28,7 @@ use syntax::abi::Abi; use syntax::ast; use syntax::attr; use hir; -use hir::intravisit::{Visitor, NestedVisitMode}; +use hir::intravisit::{Visitor}; use hir::itemlikevisit::ItemLikeVisitor; use hir::intravisit; @@ -89,8 +89,8 @@ struct ReachableContext<'a, 'tcx: 'a> { } impl<'a, 'tcx> Visitor<'tcx> for ReachableContext<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_expr(&mut self, expr: &'tcx hir::Expr) { diff --git a/src/librustc/middle/region.rs b/src/librustc/middle/region.rs index ed777d58c25aa..c2a34fca6e138 100644 --- a/src/librustc/middle/region.rs +++ b/src/librustc/middle/region.rs @@ -31,7 +31,7 @@ use syntax::ast::{self, NodeId}; use syntax_pos::Span; use hir; -use hir::intravisit::{self, Visitor, FnKind, NestedVisitMode}; +use hir::intravisit::{self, Visitor, FnKind}; use hir::{Block, Item, FnDecl, Arm, Pat, PatKind, Stmt, Expr, Local}; #[derive(Clone, PartialEq, PartialOrd, Eq, Ord, Hash, RustcEncodable, @@ -1170,8 +1170,8 @@ impl<'ast, 'a> RegionResolutionVisitor<'ast, 'a> { } impl<'ast, 'a> Visitor<'ast> for RegionResolutionVisitor<'ast, 'a> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'ast>, NestedVisitMode)> { - Some((&self.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'ast>> { + Some(&self.map) } fn visit_block(&mut self, b: &'ast Block) { diff --git a/src/librustc/middle/resolve_lifetime.rs b/src/librustc/middle/resolve_lifetime.rs index 7b94f9b32d908..88877b5a15be2 100644 --- a/src/librustc/middle/resolve_lifetime.rs +++ b/src/librustc/middle/resolve_lifetime.rs @@ -132,10 +132,12 @@ pub fn krate(sess: &Session, impl<'a, 'tcx> Visitor<'tcx> for LifetimeContext<'a, 'tcx> { // Override the nested functions -- lifetimes follow lexical scope, // so it's convenient to walk the tree in lexical order. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.hir_map, NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.hir_map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::All } + fn visit_item(&mut self, item: &'tcx hir::Item) { // Save labels for nested items. let saved_labels_in_fn = replace(&mut self.labels_in_fn, vec![]); @@ -423,6 +425,8 @@ fn extract_labels(ctxt: &mut LifetimeContext, b: hir::ExprId) { return; impl<'v, 'a> Visitor<'v> for GatherLabels<'a> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_expr(&mut self, ex: &'v hir::Expr) { // do not recurse into closures defined in the block // since they are treated as separate fns from the POV of @@ -938,6 +942,8 @@ fn insert_late_bound_lifetimes(map: &mut NamedRegionMap, } impl<'v> Visitor<'v> for ConstrainedCollector { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_ty(&mut self, ty: &'v hir::Ty) { match ty.node { hir::TyPath(hir::QPath::Resolved(Some(_), _)) | @@ -975,6 +981,8 @@ fn insert_late_bound_lifetimes(map: &mut NamedRegionMap, } impl<'v> Visitor<'v> for AllCollector { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_lifetime(&mut self, lifetime_ref: &'v hir::Lifetime) { self.regions.insert(lifetime_ref.name); } diff --git a/src/librustc/middle/stability.rs b/src/librustc/middle/stability.rs index 7417509e5b78b..33507f12ac43b 100644 --- a/src/librustc/middle/stability.rs +++ b/src/librustc/middle/stability.rs @@ -234,10 +234,12 @@ impl<'a, 'tcx> Visitor<'tcx> for Annotator<'a, 'tcx> { /// Because stability levels are scoped lexically, we want to walk /// nested items in the context of the outer item, so enable /// deep-walking. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::All } + fn visit_item(&mut self, i: &'tcx Item) { let orig_in_trait_impl = self.in_trait_impl; let mut kind = AnnotationKind::Required; @@ -534,10 +536,12 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for Checker<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::OnlyBodies } + fn visit_item(&mut self, item: &'tcx hir::Item) { match item.node { hir::ItemExternCrate(_) => { diff --git a/src/librustc/middle/weak_lang_items.rs b/src/librustc/middle/weak_lang_items.rs index 30690c099194f..36ce4f98dfdff 100644 --- a/src/librustc/middle/weak_lang_items.rs +++ b/src/librustc/middle/weak_lang_items.rs @@ -125,6 +125,8 @@ impl<'a> Context<'a> { } impl<'a, 'v> Visitor<'v> for Context<'a> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_foreign_item(&mut self, i: &hir::ForeignItem) { if let Some(lang_item) = lang_items::extract(&i.attrs) { self.register(&lang_item.as_str(), i.span); diff --git a/src/librustc_borrowck/borrowck/gather_loans/mod.rs b/src/librustc_borrowck/borrowck/gather_loans/mod.rs index 96faf97d609f6..710f47f06c7c5 100644 --- a/src/librustc_borrowck/borrowck/gather_loans/mod.rs +++ b/src/librustc_borrowck/borrowck/gather_loans/mod.rs @@ -30,7 +30,7 @@ use syntax_pos::Span; use rustc::hir; use rustc::hir::Expr; use rustc::hir::intravisit; -use rustc::hir::intravisit::{Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{Visitor}; use self::restrictions::RestrictionResult; @@ -521,8 +521,8 @@ struct StaticInitializerCtxt<'a, 'tcx: 'a> { } impl<'a, 'tcx> Visitor<'tcx> for StaticInitializerCtxt<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.bccx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.bccx.tcx.map) } fn visit_expr(&mut self, ex: &'tcx Expr) { diff --git a/src/librustc_borrowck/borrowck/mod.rs b/src/librustc_borrowck/borrowck/mod.rs index 2beb62266fb35..dd87b8472e22d 100644 --- a/src/librustc_borrowck/borrowck/mod.rs +++ b/src/librustc_borrowck/borrowck/mod.rs @@ -47,7 +47,7 @@ use syntax_pos::{MultiSpan, Span}; use errors::DiagnosticBuilder; use rustc::hir; -use rustc::hir::intravisit::{self, Visitor, FnKind, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor, FnKind}; pub mod check_loans; @@ -63,8 +63,8 @@ pub struct LoanDataFlowOperator; pub type LoanDataFlow<'a, 'tcx> = DataFlowContext<'a, 'tcx, LoanDataFlowOperator>; impl<'a, 'tcx> Visitor<'tcx> for BorrowckCtxt<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_fn(&mut self, fk: FnKind<'tcx>, fd: &'tcx hir::FnDecl, diff --git a/src/librustc_const_eval/check_match.rs b/src/librustc_const_eval/check_match.rs index 6862518067c97..08116327590d6 100644 --- a/src/librustc_const_eval/check_match.rs +++ b/src/librustc_const_eval/check_match.rs @@ -29,7 +29,7 @@ use rustc::ty::{self, TyCtxt}; use rustc_errors::DiagnosticBuilder; use rustc::hir::def::*; -use rustc::hir::intravisit::{self, Visitor, FnKind, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor, FnKind}; use rustc::hir::print::pat_to_string; use rustc::hir::{self, Pat, PatKind}; @@ -42,6 +42,8 @@ use syntax_pos::Span; struct OuterVisitor<'a, 'tcx: 'a> { tcx: TyCtxt<'a, 'tcx, 'tcx> } impl<'a, 'tcx> Visitor<'tcx> for OuterVisitor<'a, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { None } + fn visit_expr(&mut self, _expr: &'tcx hir::Expr) { return // const, static and N in [T; N] - shouldn't contain anything } @@ -91,8 +93,8 @@ struct MatchVisitor<'a, 'tcx: 'a> { } impl<'a, 'tcx> Visitor<'tcx> for MatchVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_expr(&mut self, ex: &'tcx hir::Expr) { @@ -561,6 +563,8 @@ struct AtBindingPatternVisitor<'a, 'b:'a, 'tcx:'b> { } impl<'a, 'b, 'tcx, 'v> Visitor<'v> for AtBindingPatternVisitor<'a, 'b, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_pat(&mut self, pat: &Pat) { match pat.node { PatKind::Binding(.., ref subpat) => { diff --git a/src/librustc_incremental/calculate_svh/mod.rs b/src/librustc_incremental/calculate_svh/mod.rs index 01e1f4ca1f13c..6de7192b17ce4 100644 --- a/src/librustc_incremental/calculate_svh/mod.rs +++ b/src/librustc_incremental/calculate_svh/mod.rs @@ -224,6 +224,8 @@ impl<'a, 'tcx> HashItemsVisitor<'a, 'tcx> { impl<'a, 'tcx> Visitor<'tcx> for HashItemsVisitor<'a, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { None } + fn visit_item(&mut self, item: &'tcx hir::Item) { self.calculate_node_id(item.id, |v| v.visit_item(item)); visit::walk_item(self, item); diff --git a/src/librustc_incremental/calculate_svh/svh_visitor.rs b/src/librustc_incremental/calculate_svh/svh_visitor.rs index 6a045216ce9cb..59165649fdecd 100644 --- a/src/librustc_incremental/calculate_svh/svh_visitor.rs +++ b/src/librustc_incremental/calculate_svh/svh_visitor.rs @@ -513,9 +513,9 @@ macro_rules! hash_span { } impl<'a, 'hash, 'tcx> visit::Visitor<'tcx> for StrictVersionHashVisitor<'a, 'hash, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, visit::NestedVisitMode)> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { if self.hash_bodies { - Some((&self.tcx.map, visit::NestedVisitMode::OnlyBodies)) + Some(&self.tcx.map) } else { None } diff --git a/src/librustc_metadata/astencode.rs b/src/librustc_metadata/astencode.rs index 8a24062f8f35d..52a0dc8a6191d 100644 --- a/src/librustc_metadata/astencode.rs +++ b/src/librustc_metadata/astencode.rs @@ -11,7 +11,7 @@ use rustc::hir; use rustc::hir::map as ast_map; -use rustc::hir::intravisit::{Visitor, IdRangeComputingVisitor, IdRange, NestedVisitMode}; +use rustc::hir::intravisit::{Visitor, IdRangeComputingVisitor, IdRange}; use cstore::CrateMetadata; use encoder::EncodeContext; @@ -75,8 +75,8 @@ struct SideTableEncodingIdVisitor<'a, 'b: 'a, 'tcx: 'b> { } impl<'a, 'b, 'tcx> Visitor<'tcx> for SideTableEncodingIdVisitor<'a, 'b, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.ecx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.ecx.tcx.map) } fn visit_id(&mut self, id: ast::NodeId) { diff --git a/src/librustc_metadata/encoder.rs b/src/librustc_metadata/encoder.rs index 67b0be0dfcdac..41c8a9728fa2e 100644 --- a/src/librustc_metadata/encoder.rs +++ b/src/librustc_metadata/encoder.rs @@ -39,7 +39,7 @@ use syntax_pos; use rustc::hir::{self, PatKind}; use rustc::hir::itemlikevisit::ItemLikeVisitor; -use rustc::hir::intravisit::{Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{Visitor}; use rustc::hir::intravisit; use super::index_builder::{FromId, IndexBuilder, Untracked}; @@ -983,8 +983,8 @@ struct EncodeVisitor<'a, 'b: 'a, 'tcx: 'b> { } impl<'a, 'b, 'tcx> Visitor<'tcx> for EncodeVisitor<'a, 'b, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.index.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.index.tcx.map) } fn visit_expr(&mut self, ex: &'tcx hir::Expr) { intravisit::walk_expr(self, ex); diff --git a/src/librustc_mir/mir_map.rs b/src/librustc_mir/mir_map.rs index 1d362129b1bce..ecc978542e127 100644 --- a/src/librustc_mir/mir_map.rs +++ b/src/librustc_mir/mir_map.rs @@ -30,7 +30,7 @@ use rustc::traits::Reveal; use rustc::ty::{self, Ty, TyCtxt}; use rustc::ty::subst::Substs; use rustc::hir; -use rustc::hir::intravisit::{self, FnKind, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, FnKind, Visitor}; use syntax::abi::Abi; use syntax::ast; use syntax_pos::Span; @@ -144,8 +144,8 @@ impl<'a, 'gcx> BuildMir<'a, 'gcx> { } impl<'a, 'tcx> Visitor<'tcx> for BuildMir<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } // Const and static items. diff --git a/src/librustc_passes/consts.rs b/src/librustc_passes/consts.rs index 94110ca58f856..5946c3840e471 100644 --- a/src/librustc_passes/consts.rs +++ b/src/librustc_passes/consts.rs @@ -48,7 +48,7 @@ use rustc::lint::builtin::CONST_ERR; use rustc::hir::{self, PatKind}; use syntax::ast; use syntax_pos::Span; -use rustc::hir::intravisit::{self, FnKind, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, FnKind, Visitor}; use std::collections::hash_map::Entry; use std::cmp::Ordering; @@ -233,8 +233,8 @@ impl<'a, 'gcx> CheckCrateVisitor<'a, 'gcx> { } impl<'a, 'tcx> Visitor<'tcx> for CheckCrateVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_item(&mut self, i: &'tcx hir::Item) { diff --git a/src/librustc_passes/hir_stats.rs b/src/librustc_passes/hir_stats.rs index 28a913de26fe6..8c51a50526c7d 100644 --- a/src/librustc_passes/hir_stats.rs +++ b/src/librustc_passes/hir_stats.rs @@ -106,7 +106,7 @@ impl<'k> StatCollector<'k> { } impl<'v> hir_visit::Visitor<'v> for StatCollector<'v> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'v>, hir_visit::NestedVisitMode)> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { panic!("visit_nested_xxx must be manually implemented in this visitor") } diff --git a/src/librustc_passes/loops.rs b/src/librustc_passes/loops.rs index 9356a0ce17d67..a2c261a36a606 100644 --- a/src/librustc_passes/loops.rs +++ b/src/librustc_passes/loops.rs @@ -13,7 +13,7 @@ use rustc::session::Session; use rustc::dep_graph::DepNode; use rustc::hir::map::Map; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::hir; use syntax::ast; use syntax_pos::Span; @@ -60,8 +60,8 @@ pub fn check_crate(sess: &Session, map: &Map) { } impl<'a, 'ast> Visitor<'ast> for CheckLoopVisitor<'a, 'ast> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'ast>, NestedVisitMode)> { - Some((&self.hir_map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'ast>> { + Some(&self.map) } fn visit_item(&mut self, i: &'ast hir::Item) { diff --git a/src/librustc_passes/rvalues.rs b/src/librustc_passes/rvalues.rs index 36492538d4bfb..3e2b2b62fa822 100644 --- a/src/librustc_passes/rvalues.rs +++ b/src/librustc_passes/rvalues.rs @@ -18,7 +18,7 @@ use rustc::ty::{self, TyCtxt, ParameterEnvironment}; use rustc::traits::Reveal; use rustc::hir; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use syntax::ast; use syntax_pos::Span; @@ -32,8 +32,8 @@ struct RvalueContext<'a, 'tcx: 'a> { } impl<'a, 'tcx> Visitor<'tcx> for RvalueContext<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } fn visit_fn(&mut self, diff --git a/src/librustc_passes/static_recursion.rs b/src/librustc_passes/static_recursion.rs index a70ad25f50545..f8d7e100dabf1 100644 --- a/src/librustc_passes/static_recursion.rs +++ b/src/librustc_passes/static_recursion.rs @@ -20,7 +20,7 @@ use rustc::util::nodemap::NodeMap; use syntax::ast; use syntax::feature_gate::{GateIssue, emit_feature_err}; use syntax_pos::Span; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::hir; use std::cell::RefCell; @@ -36,6 +36,8 @@ struct CheckCrateVisitor<'a, 'ast: 'a> { } impl<'a, 'ast: 'a> Visitor<'ast> for CheckCrateVisitor<'a, 'ast> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'ast>> { None } + fn visit_item(&mut self, it: &'ast hir::Item) { match it.node { hir::ItemStatic(..) | @@ -200,8 +202,8 @@ impl<'a, 'ast: 'a> CheckItemRecursionVisitor<'a, 'ast> { } impl<'a, 'ast: 'a> Visitor<'ast> for CheckItemRecursionVisitor<'a, 'ast> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'ast>, NestedVisitMode)> { - Some((&self.ast_map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'ast>> { + Some(&self.ast_map) } fn visit_item(&mut self, it: &'ast hir::Item) { diff --git a/src/librustc_privacy/lib.rs b/src/librustc_privacy/lib.rs index eb742b8788981..644f681a6dac3 100644 --- a/src/librustc_privacy/lib.rs +++ b/src/librustc_privacy/lib.rs @@ -120,10 +120,12 @@ impl<'a, 'tcx> EmbargoVisitor<'a, 'tcx> { impl<'a, 'tcx> Visitor<'tcx> for EmbargoVisitor<'a, 'tcx> { /// We want to visit items in the context of their containing /// module and so forth, so supply a crate for doing a deep walk. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::All } + fn visit_item(&mut self, item: &'tcx hir::Item) { let inherited_item_level = match item.node { // Impls inherit level from their types and traits @@ -432,10 +434,12 @@ impl<'a, 'tcx> PrivacyVisitor<'a, 'tcx> { impl<'a, 'tcx> Visitor<'tcx> for PrivacyVisitor<'a, 'tcx> { /// We want to visit items in the context of their containing /// module and so forth, so supply a crate for doing a deep walk. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::All } + fn visit_item(&mut self, item: &'tcx hir::Item) { let orig_curitem = replace(&mut self.curitem, item.id); intravisit::walk_item(self, item); @@ -615,6 +619,8 @@ impl<'a, 'tcx> ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> { } impl<'a, 'b, 'tcx, 'v> Visitor<'v> for ObsoleteCheckTypeForPrivatenessVisitor<'a, 'b, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_ty(&mut self, ty: &hir::Ty) { if let hir::TyPath(hir::QPath::Resolved(_, ref path)) = ty.node { if self.inner.path_is_private_type(path) { @@ -640,10 +646,12 @@ impl<'a, 'b, 'tcx, 'v> Visitor<'v> for ObsoleteCheckTypeForPrivatenessVisitor<'a impl<'a, 'tcx> Visitor<'tcx> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> { /// We want to visit items in the context of their containing /// module and so forth, so supply a crate for doing a deep walk. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::All)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.tcx.map) } + fn nested_visit_mode(&mut self) -> NestedVisitMode { NestedVisitMode::All } + fn visit_item(&mut self, item: &'tcx hir::Item) { match item.node { // contents of a private mod can be reexported, so we need diff --git a/src/librustc_trans/symbol_names_test.rs b/src/librustc_trans/symbol_names_test.rs index aa23a18172276..bdd8d00acd41f 100644 --- a/src/librustc_trans/symbol_names_test.rs +++ b/src/librustc_trans/symbol_names_test.rs @@ -67,6 +67,8 @@ impl<'a, 'tcx> SymbolNamesTest<'a, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for SymbolNamesTest<'a, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { None } + fn visit_item(&mut self, item: &'tcx hir::Item) { self.process_attrs(item.id); intravisit::walk_item(self, item); diff --git a/src/librustc_typeck/check/mod.rs b/src/librustc_typeck/check/mod.rs index cb9d098d2a527..2909f9210095b 100644 --- a/src/librustc_typeck/check/mod.rs +++ b/src/librustc_typeck/check/mod.rs @@ -119,7 +119,7 @@ use syntax::symbol::{Symbol, InternedString, keywords}; use syntax::util::lev_distance::find_best_match_for_name; use syntax_pos::{self, BytePos, Span}; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::hir::itemlikevisit::ItemLikeVisitor; use rustc::hir::{self, PatKind}; use rustc::hir::print as pprust; @@ -538,8 +538,8 @@ struct CheckItemTypesVisitor<'a, 'tcx: 'a> { ccx: &'a CrateCtxt<'a, 'tcx> } struct CheckItemBodiesVisitor<'a, 'tcx: 'a> { ccx: &'a CrateCtxt<'a, 'tcx> } impl<'a, 'tcx> Visitor<'tcx> for CheckItemTypesVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.ccx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.ccx.tcx.map) } fn visit_item(&mut self, i: &'tcx hir::Item) { @@ -700,6 +700,8 @@ impl<'a, 'gcx, 'tcx> GatherLocalsVisitor<'a, 'gcx, 'tcx> { } impl<'a, 'gcx, 'tcx> Visitor<'gcx> for GatherLocalsVisitor<'a, 'gcx, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'gcx>> { None } + // Add explicitly-declared locals. fn visit_local(&mut self, local: &'gcx hir::Local) { let o_ty = match local.ty { diff --git a/src/librustc_typeck/check/regionck.rs b/src/librustc_typeck/check/regionck.rs index 2540faa98369f..3d39aed2e16d8 100644 --- a/src/librustc_typeck/check/regionck.rs +++ b/src/librustc_typeck/check/regionck.rs @@ -99,7 +99,7 @@ use std::mem; use std::ops::Deref; use syntax::ast; use syntax_pos::Span; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::hir::{self, PatKind}; use self::SubjectNode::Subject; @@ -480,8 +480,8 @@ impl<'a, 'gcx, 'tcx> Visitor<'gcx> for RegionCtxt<'a, 'gcx, 'tcx> { // hierarchy, and in particular the relationships between free // regions, until regionck, as described in #3238. - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'gcx>, NestedVisitMode)> { - Some((&self.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'gcx>> { + Some(&self.tcx.map) } fn visit_fn(&mut self, _fk: intravisit::FnKind<'gcx>, fd: &'gcx hir::FnDecl, diff --git a/src/librustc_typeck/check/upvar.rs b/src/librustc_typeck/check/upvar.rs index 796d3016b0bb1..92432c0e55f8a 100644 --- a/src/librustc_typeck/check/upvar.rs +++ b/src/librustc_typeck/check/upvar.rs @@ -50,7 +50,7 @@ use rustc::infer::UpvarRegion; use syntax::ast; use syntax_pos::Span; use rustc::hir; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::util::nodemap::NodeMap; /////////////////////////////////////////////////////////////////////////// @@ -78,8 +78,8 @@ struct SeedBorrowKind<'a, 'gcx: 'a+'tcx, 'tcx: 'a> { } impl<'a, 'gcx, 'tcx> Visitor<'gcx> for SeedBorrowKind<'a, 'gcx, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'gcx>, NestedVisitMode)> { - Some((&self.fcx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'gcx>> { + Some(&self.fcx.tcx.map) } fn visit_expr(&mut self, expr: &'gcx hir::Expr) { @@ -490,8 +490,8 @@ impl<'a, 'gcx, 'tcx> AdjustBorrowKind<'a, 'gcx, 'tcx> { } impl<'a, 'gcx, 'tcx> Visitor<'gcx> for AdjustBorrowKind<'a, 'gcx, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'gcx>, NestedVisitMode)> { - Some((&self.fcx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'gcx>> { + Some(&self.fcx.tcx.map) } fn visit_fn(&mut self, diff --git a/src/librustc_typeck/check/wfcheck.rs b/src/librustc_typeck/check/wfcheck.rs index ef3ac5da6cc4a..bb06847f7bed8 100644 --- a/src/librustc_typeck/check/wfcheck.rs +++ b/src/librustc_typeck/check/wfcheck.rs @@ -609,6 +609,8 @@ fn reject_shadowing_type_parameters(tcx: TyCtxt, span: Span, def_id: DefId) { } impl<'ccx, 'tcx, 'v> Visitor<'v> for CheckTypeWellFormedVisitor<'ccx, 'tcx> { + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'v>> { None } + fn visit_item(&mut self, i: &hir::Item) { debug!("visit_item: {:?}", i); self.check_item_well_formed(i); diff --git a/src/librustc_typeck/check/writeback.rs b/src/librustc_typeck/check/writeback.rs index 3906722aaab38..6f95a3da29ed7 100644 --- a/src/librustc_typeck/check/writeback.rs +++ b/src/librustc_typeck/check/writeback.rs @@ -27,7 +27,7 @@ use syntax::ast; use syntax_pos::{DUMMY_SP, Span}; use rustc::hir::print::pat_to_string; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::hir::{self, PatKind}; /////////////////////////////////////////////////////////////////////////// @@ -187,8 +187,8 @@ impl<'cx, 'gcx, 'tcx> WritebackCx<'cx, 'gcx, 'tcx> { // traffic in node-ids or update tables in the type context etc. impl<'cx, 'gcx, 'tcx> Visitor<'gcx> for WritebackCx<'cx, 'gcx, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'gcx>, NestedVisitMode)> { - Some((&self.fcx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'gcx>> { + Some(&self.fcx.tcx.map) } fn visit_stmt(&mut self, s: &'gcx hir::Stmt) { diff --git a/src/librustc_typeck/collect.rs b/src/librustc_typeck/collect.rs index 09e54cb9c5366..0ae0d8942955a 100644 --- a/src/librustc_typeck/collect.rs +++ b/src/librustc_typeck/collect.rs @@ -83,7 +83,7 @@ use syntax::symbol::{Symbol, keywords}; use syntax_pos::Span; use rustc::hir::{self, map as hir_map, print as pprust}; -use rustc::hir::intravisit::{self, Visitor, NestedVisitMode}; +use rustc::hir::intravisit::{self, Visitor}; use rustc::hir::def::{Def, CtorKind}; use rustc::hir::def_id::DefId; @@ -178,8 +178,8 @@ impl<'a, 'tcx> CollectItemTypesVisitor<'a, 'tcx> { } impl<'a, 'tcx> Visitor<'tcx> for CollectItemTypesVisitor<'a, 'tcx> { - fn nested_visit_map(&mut self) -> Option<(&hir::map::Map<'tcx>, NestedVisitMode)> { - Some((&self.ccx.tcx.map, NestedVisitMode::OnlyBodies)) + fn nested_visit_map(&mut self) -> Option<&hir::map::Map<'tcx>> { + Some(&self.ccx.tcx.map) } fn visit_item(&mut self, item: &'tcx hir::Item) {