db/migrate/20090318164300_remove_user_ip_from_spam_reports.rb @@ -2,24 +2,14 @@ Fixes Features - add alternative download format for linux/windows -- provide adobe media player feed +- add search to comments page Possible -- remember me when logging in -- textile for comments -- author edit comment for short time -- add a blog - try "application/quicktime" content type to open movie directly in quicktime (see apple.com/quicktime for examples) -- sort tag page in descending order +- provide adobe media player feed - integration with miro (getmiro.com) -- add search to comments page -- improve CSS design - -Spam Reporting -x add spam report to admin navigation -x add AJAX report link to comments page -x add confirm link to spam report list -x show spam report details with matching comments -x add hit_count to spam report and increment upon similar reports -x don't allow comment post if it matches spam report with enough hits -? add user's ip to spam report or remove attribute ++ improve CSS design ++ author edit comment for short time ++ textile for comments ++ remember me when logging in ++ add a blog TODO @@ -2,7 +2,7 @@ <% @comment_counter += 1 -%> <%= tag :hr if @comment_counter > 1 %> <% div_for comment do %> - <%- unless current_page? episode_path(comment.episode) -%> + <%- if comment.episode && !current_page?(comment.episode) -%> <h4> Episode #<%= comment.episode.position %>: <%= link_to h(comment.episode.name), episode_path(:id => comment.episode, :anchor => dom_id(comment)) %> app/views/comments/_comment.html.erb @@ -9,7 +9,7 @@ # # It's strongly recommended to check this file into your version control system. -ActiveRecord::Schema.define(:version => 20090311181239) do +ActiveRecord::Schema.define(:version => 20090318164300) do create_table "comments", :force => true do |t| t.integer "episode_id" @@ -56,7 +56,6 @@ ActiveRecord::Schema.define(:version => 20090311181239) do t.string "comment_ip" t.string "comment_site_url" t.string "comment_name" - t.string "user_ip" t.datetime "confirmed_at" t.datetime "created_at" t.datetime "updated_at" @@ -80,8 +79,8 @@ ActiveRecord::Schema.define(:version => 20090311181239) do t.datetime "updated_at" end - add_index "taggings", ["tag_id"], :name => "index_taggings_on_tag_id" add_index "taggings", ["episode_id"], :name => "index_taggings_on_episode_id" + add_index "taggings", ["tag_id"], :name => "index_taggings_on_tag_id" create_table "tags", :force => true do |t| t.string "name" db/schema.rb @@ -3,7 +3,6 @@ one: comment_ip: MyString comment_site_url: MyString comment_name: MyString - user_ip: MyString confirmed_at: two: @@ -11,5 +10,4 @@ two: comment_ip: MyString comment_site_url: MyString comment_name: MyString - user_ip: MyString confirmed_at: 2009-03-11 09:51:21 spec/fixtures/spam_reports.yml @@ -48,7 +48,7 @@ describe Comment do it "should not find matching spam reports by blank values" do Comment.delete_all - report = SpamReport.create!(:user_ip => '') + report = SpamReport.create!(:comment_ip => '') comment = Factory(:comment, :user_ip => '') comment.matching_spam_reports.should_not include(report) comment.should_not be_spammish spec/models/comment_spec.rb e52bb95d91b83bed8b06a3dea4c1cf58765f3505 Ryan Bates ryan@railscasts.com http://github.com/ryanb/railscasts/commit/a0ed40368d1414ca24383feab124955e7c54f358 a0ed40368d1414ca24383feab124955e7c54f358 2009-03-18T09:47:41-07:00 2009-03-18T09:47:41-07:00 removing user_ip field from spam reports because it was not being used 475a9db660a16bdaa9b74e666d0468e309fb3b5a Ryan Bates ryan@railscasts.com