samgranieri (Sam Granieri)

Consolidate Object#to_param and #to_query core extensions

Ruby 1.9.2: rational.rb is deprecated

Ruby 1.9.2: URI.escape is obsolete

Ruby 1.9 doesn't recognize EM SPACE as whitespace, breaking String#strip

Give useful test:isolated failures

CI breakage

Extracted localized_cache.rb from ActionController, added it to AbstractController and made ActionMailer use it.

Allow :instance_reader to be given to superclass_delegating_accessor as well.

Use I18n on ActionMailer subjects by default.

More refactoring on ActionMailer::Base.

Make tests run without deprecation warning (just one left).

Another refactoring on AM. body is deprecated, use render instead.

Add some basic render_test to AbstractController.

Improve AbstractController layouts coverage.

Move some of helper tests to AbstractController.

Move all render and layout pieces required in ActionMailer from ActionController to AbstractController.

Remove ActionMailer helpers and rely on AbstractController one.

Refactor ActionMailer layout and remove legacy one.

abstract all of the ActionMailer delivery methods into their own classes. thereby the following are equivalent

Change Event#thread_id to #transaction_id. Defaults to one "transaction" per thread but you can explicitly declare the start of a new one. This makes it possible for each request to have it own id.

Make it possible to have IDs per request

New semantics eliminate the need for __send__

This is all that's needed in 1.8.7+

Reduce TextTemplate cost for simple cases

Reorganize CSRF a bit

AS::Notifications.subscribe blocks are now yielded the arguments to pass to AS::Notifications::Event.new

Edinburgh TimeZone references "Europe/London" instead of "Europe/Dublin" [#3310 state:resolved]

Bundle Tzinfo 0.3.15

Tzinfo bundling task: unpack tzinfo with lib directory preserved

Tests pass again

Some more generation tests

Extract routing controller stub helper into abstract unit

Enable named route tests

Start migrating AC routing tests into dispatch folder

Fix test failures due to requiring rails without AS in load path

Update initializable

Duplicate AS code no longer needed

Fix rake dev and update vendored Thor.

#include should be #extend

Some optimizations on AS::Notifications. This does not change the public-facing API.

Clean up flash a bit

Tweak CI for toplevel gem bundle

Clean up flash a bit

Clean up parameter logging some

Clean up and update cookies

Fixes expires_now and cleans things up a bit

Extract #head into its own module and simplify it

Base setup for config object in AC.

Splat calls to_a not to_ary [#3423 state:resolved]

Restore `rake routes` [#3402 state:resolved]

Use rails/rack-mount

Always add actionpack/lib to load path for isolated tests

Fix error_messages_for when instance variable names are given.

Have all the tests running off a single Gemfile

Start rewriting some internal tests to use the new routing dsl

Run bundler before AM and AMo tests

New routing dsl

Group together all the old routing dsl logic

Need to use "use_controllers" for nonexistent controller in AM test

Fixed: #without_typecast should only disable typecasting on the duplicated attributes [#3387 state:resolved]

Don't use use_controllers in routing tests

This is routing error message test is tightly coupled to the implementation. Just test that it raises an exception.

Drop legacy support for case insensitive controller recognition

Fix brittle query string comparisons

Fix brittle query string comparisons

Fix standalone run of routing test. Only reference controllers that are provided in fake_controllers

Stop using with_controllers in tests

No longer need this special routing exception message because these kinds of ambiguous generations are deprecated

Drop support for routing :generate_all

Invalid route requirements should always raise an exception even if they are unused

Remove some remnants of config.gem

By default use ActiveModel API in controller generators, unless otherwise specified [#3123 status:resolved]

Make app generatoor specs green once again.

Refactoring attributes/types [#3348 state:resolved]

Bring agnosticism to error_messages_for.

Unify class_inheritable_accessor and extlib_inheritable_accessor and allow responder to be set in the class level.

Use rails/rack

Use public submodule url

Make ruby-debug optional

exists? method now uses ARel

Added arel_attributes_values methods, refactored locking and AR#update to use this method

Merge commit 'rails/master'

Merge commit 'rails/master'

Calculations now use Arel to construct the query.

construct_finder_sql now use Arel

Refactored locking update

Merge commit 'rails/master'

Changed locking to use Arel. Arel updated

Added ruby-debug

Remove connection method definition, since it's called just once.

More progress on migrations. Arel updated.

Added Arel integration to migration's version update table

Arel updated

Removed blank lines

Require Arel

Added arel as a submodule. This is temporary and will make development/testing easier.

More robust console test

Revert "Revert "Fix Dispatch.new so passenger works" as it broke the build"

Revert "Fix Dispatch.new so passenger works" as it broke the build

Fix Dispatch.new so passenger works

Only draw default route once

Use with_routing helper in tests instead of modifying global route set

Redraw default routes on all internal integration tests. We don't need SimpleRouteCase anymore

Avoid creating new controller constants during test runtime. All routable controllers should be defined beforehand.

Run AP isolated tests on CI

Moved shared form helper models into fake_models

NumberHelper depends on big decimal extensions

Changing directories during the test breaks file loading when ran by itself

Don't load rubygems for isolated tests

Move improved isolated test runner to AP

File extra test folders into controller, dispatch, or template

Add custom "with_routing" to internal tests to fix reseting session after using

Cleanup whitespace introduced in 8377646 and f4f6888

add indifferent access to the attributes

update_attribute(s) added to Active Resource

Remove all calls to Rails::Initializer from boot.rb

Remove a duplicate initializer

Change Rails::Application to a class that is inherited from.

Remove unneeded files from the railties test directory

Fix the broken railties isolation tests

reduce max size of fixture IDs to fix sqlite2 tests, because sqlite2 was getting negative and changing values for ID field. See http://www.sqlite.org/datatypes.html

make mysql and postgresql rebuild databases on every CI build, to prevent breakages such as collation and character set changing

Merge branch '2-3-stable' of git@github.com:rails/rails into 2-3-stable

Introduce :almost keyword for distance_of_time_in_words. Make 1.75 days - 2 days return '2 days'.

Enhancing distance_of_time_in_words to prefix year output with over and about depending upon how many months have elapsed

Make has_one with :conditions hash scope build or creation of the associated object with those conditions

Fixes a bug where layouts provided with an absolute path would not be found because they were prefixed by 'layouts'. This bug only appears if the path does not contain the word 'layouts'.

include nokogiri gem, so activesupport nokogiri tests run

The DomAssertions now also strip surrounding whitespace inside tags.

Made assert_dom_equal and assert_dom_not_equal ignore meaningless whitespace.

Rewrote ActionView::TestCase.

Prefix Internet Explorer's accepted mime types with sensible defaults.

Fix variable error in Nokogiri XmlMini code [#3242 state:resolved]

Removes examples so it can be replaced with separate repo

Fix brittle content-type check. [#1956 state:committed]

Enable use of MySQL stored procedures by default.

Allow Nokogiri XmlMini backend to process cdata elements

Avoid inadvertently loading an old tzinfo gem

Move railties/lib/* into railties/lib/*

Clean up log output for rendered templates

Resurrect AC::Benchmarking [#3140 state:resolved]

Remove dead requries to AC integration. Rely on autoloads instead

SessionRestoreError belongs in AD

Move helpers specific to functional tests out of TestProcess into AC::TestCase

Move integration test runner into ActionDispatch

More places to bump rack-test version [#3250 state:resolved]

Bump rack-test required version to 0.5

Fixes Sam Ruby tests suite.

Merge commit 'jose/orchestra'

fixed ActiveModel::Lint typos [#3236 state:resolved]

Instrumenting cache stores.

Instrument create and deliver in ActionMailer.

Use NewCallbacks on ActionDispatch::Callbacks.

Add Orchestra instrumentation to fragment and page caching.

Instrument process_action, render and sql.

Added Orchestra.