sha1.js @@ -123,7 +123,7 @@ var consoleController = { url: self.url + 'query.php', type: 'POST', dataType: 'json', - data: { query: val}, + data: { query: val, signature: hex_hmac_sha1( jQuery("#wpconsolesecret").val(), val ) }, success: function(j) { // if result is not an error if (self.check(j)) { @@ -183,4 +183,4 @@ var consoleController = { } } -jQuery(document).ready(function() { consoleController.init(); }); \ No newline at end of file +jQuery(document).ready(function() { consoleController.init(); }); console.js @@ -3,7 +3,18 @@ require('common.php'); set_error_handler('console_error_handler'); +$secret = get_option('wordpress-console-secret'); +if ( !$secret ) + return; + +if ( !isset($_POST['signature']) || !$_POST['signature'] ) + return; + if (isset($_POST['query'])) { + + if ( hash_hmac('sha1', stripslashes($_POST['query']), $secret) != $_POST['signature'] ) + return; + $existing_vars = get_defined_vars(); // restore session variables if they exist @@ -56,4 +67,4 @@ if (isset($_POST['query'])) { error('Error initializing session.'); } -?> \ No newline at end of file +?> query.php @@ -15,12 +15,18 @@ function console_admin_css() { function console_admin_javascripts() { wp_enqueue_script('console', WP_PLUGIN_URL . '/wordpress-console/console.js', array('jquery')); + wp_enqueue_script('sha1', WP_PLUGIN_URL . '/wordpress-console/sha1.js', array('jquery')); } // THE CONSOLE function console_admin_page() { + $secret = get_option('wordpress-console-secret'); + if ( !$secret ) { + $secret = md5( time() . php_uname("n") . $_SERVER['REMOTE_ADDR'] . $_SERVER['HTTP_HOST'] . __FILE__ ); + update_option('wordpress-console-secret', $secret); + } $page_url = str_replace( '%7E', '~', $_SERVER['REQUEST_URI']); - + echo '<input type="hidden" id="wpconsolesecret" value="'.$secret.'"'; echo '<div id="wrap">'; echo '<h2>WordPress Console: "?" for help menu</h2>'; echo '<div id="wrapper">'; @@ -36,4 +42,4 @@ function console_hooks() { } add_action('admin_menu', 'console_hooks'); -?> \ No newline at end of file +?> wordpress-console.php 177efc205b75326209bc907420960e77fee3926a sant0sk1 sant0sk1@b8457f37-d9ea-0310-8a92-e5e31aec5664 http://github.com/sant0sk1/wordpress-console/commit/cbd7add5ae56798809f6f818f8c481226374fcb3 cbd7add5ae56798809f6f818f8c481226374fcb3 2009-06-24T17:16:27-07:00 2009-06-24T17:16:27-07:00 require shared secret to run query (patch by apokalyptik). Closes #1 git-svn-id: http://svn.wp-plugins.org/wordpress-console/trunk@129229 b8457f37-d9ea-0310-8a92-e5e31aec5664 b3525d162c0b1ab667cf710faacb8fb58072b9e5 sant0sk1 sant0sk1@b8457f37-d9ea-0310-8a92-e5e31aec5664