Optimization: use AnyRef map for Namer -> Typer tree handoff #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And uses a map per-compilation unit, rather than one per Typer. One small change required: we now need to clear this map in the the interactive compiler which reuses compilation units, rather than in the call to `Typer#reset`.
These are a hotspot in the backend.
gkossakowski
added a commit
that referenced
this pull request
Feb 10, 2014
Optimization: use AnyRef map for Namer -> Typer tree handoff
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And uses a map per-compilation unit, rather than one per Typer.
No need to cleanup in
reset(), this way.Review by @gkossakowski
In my topic/opt2 branch, I used tree attachments as an alternative
to using a map at all. But when I submitted a PR with that change,
the test suite picked up a subtle change in behaviour that I didn't
have time to investigate. Switching to
AnyRefMapis a lower-riskpatch, but still worthwhile for performance.