@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buffer, int len) */ if (0x03030303 < acc || 0xffffffff - de < (acc *= 85)) - error("invalid base85 sequence %.5s", buffer-5); + return error("invalid base85 sequence %.5s", buffer-5); acc += de; say1(" %08x", acc); base85.c 192a6be2a77ab3bf446237fdf6575b0aca863d9e Jerald Fitzjerald jfj@freemail.gr http://github.com/schacon/git-source/commit/86d14e1b1d1063fc943c71edc8b05e1ce32c1602 86d14e1b1d1063fc943c71edc8b05e1ce32c1602 2007-05-30T15:03:50-07:00 2007-05-30T05:39:58-07:00 decode_85(): fix missing return. When the function detected an invalid base85 sequence, it issued an error message but forgot to return error status at that point and kept going. Signed-off-by: Jerald Fitzjerald <jfj@freemail.gr> Signed-off-by: Junio C Hamano <junkio@cox.net> b441e296412b6bb41806b5392fc78e6df288bb5a Junio C Hamano junkio@cox.net