Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use_ok() to 0.98 features #287

Closed
schwern opened this issue Apr 23, 2012 · 0 comments
Closed

Revert use_ok() to 0.98 features #287

schwern opened this issue Apr 23, 2012 · 0 comments

Comments

@schwern
Copy link
Contributor

schwern commented Apr 23, 2012

The changes to use_ok() in the 0.98 alphas to allow lexical effect have unfortunately complicated a function that is generally considered of only narrow use. The functionality change to allow lexical effect has caused some test compatibility problems. It is not considered worth the trouble.

See http://www.nntp.perl.org/group/perl.qa/2012/04/msg13119.html for discussion.

  • Revert use_ok() back to its 0.98 functionality (no lexical effect should leak out)
  • Retain any bug fixes

For bonus points, move the use_ok functionality, without the test code, into a library. It's good code and does a tricky thing.

schwern added a commit that referenced this issue Apr 26, 2012
It was causing backwards compat problems, the implementation was complex and
use_ok() is generally considered useless if not actively harmful.

For #287
schwern added a commit that referenced this issue Apr 26, 2012
@schwern schwern closed this as completed May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant