@@ -1,5 +1,6 @@ class VotesController < ApplicationController + # TODO: Feels like a good chunk of this should be in the Vote model... def vote hiring_stage = HiringStage.find_by_hiring_stage_id( params[:hiring_stage_id] ) vetting_stage = VettingStage.find_by_id( params[:vetting_stage_id] ) @@ -16,6 +17,9 @@ class VotesController < ApplicationController end end + # Tell the hiring stage to check and see whether or not the applicant should be advanced to the next vetting stage + hiring_stage.advance_applicant? + respond_to do |format| format.html { redirect_to( hiring_stage.position ) } format.xml { head :ok } app/controllers/votes_controller.rb @@ -12,10 +12,13 @@ class HiringStage < ActiveRecord::Base belongs_to :vetting_stage has_many :votes -=begin - has_many :yea_votes, :class_name => 'Vote', :conditions => "vote_value = 1" - has_many :nay_votes, :class_name => 'Vote', :conditions => "vote_value = 0" -=end + + + # ------------------------------------------------------------ Class Methods ------------------------------------------------------------ # + + + # ------------------------------------------------------------ Instance Methods ------------------------------------------------------------ # + def construct_from_basic_elements( applicant, position, vetting_stage ) self.applicant = applicant @@ -25,16 +28,29 @@ class HiringStage < ActiveRecord::Base self.save! end - -=begin - def find_vote_count_for_vetting_stage( vetting_stage, type = :all ) - if ( :all == type ) - return votes.count( :conditions => "vetting_stage_id = #{vetting_stage.id}" ) - elsif ( :yea == type ) - return yea_votes.count( :conditions => "vetting_stage_id = #{vetting_stage.id}" ) - elsif ( :nay == type ) - return nay_votes.count( :conditions => "vetting_stage_id = #{vetting_stage.id}" ) + + # An applicant gets advanced if all the votes from all the users at the current vetting stage are 1 + def advance_applicant?() + if voting_percentage_was_reached?() + self.position.shift_applicant_to_stage( :next, self.applicant ) end end -=end + +private + + # Did the number of votes cast at this hiring stage meet or exceed the concensus needed to move this applicant to the next stage? + def voting_percentage_was_reached?() + return CONSENSUS_PERCENTAGE.to_f <= voting_percentage().to_f + end + + + # Calculates the percentage of votes for the applicant ('yea' votes are any that are true, or equal to 1) + def voting_percentage() + votes = Vote.find_votes_by_hiring_stage( self ) + vote_array = votes.map { |vote| vote.vote_value == true ? 1 : 0 } + sum = vote_array.inject { |sum,x| sum ? sum + x : x } + percent = votes.length.to_f / sum.to_f + + return percent + end end app/models/hiring_stage.rb @@ -84,16 +84,4 @@ class Position < ActiveRecord::Base return Vote.find( :all, :conditions => "applicant_id = #{applicant.id} AND position_id = #{self.id} AND vetting_stage_id = #{vetting_stage.id} AND vote_value = 0" ) end end - -=begin - def find_reviewers( applicant, vetting_stage, voting_state = :all ) - if ( :all == voting_state ) - - elsif( :voted == voting_state ) - - elsif( :unvoted == voting_state ) - - end - end -=end end app/models/position.rb @@ -11,11 +11,17 @@ class Vote < ActiveRecord::Base # ------------------------------------------------------------ Class Methods ------------------------------------------------------------ # + # TODO: I think I can just pass in the hiring stage here and infer the vetting stage from it def self.find_vote_by_hiring_stage_and_vetting_stage( hiring_stage, vetting_stage ) return self.find( :first, :conditions => "hiring_stage_id = #{hiring_stage.id} AND vetting_stage_id = #{vetting_stage.id}" ) end + def self.find_votes_by_hiring_stage( hiring_stage ) + return self.find( :all, :conditions => "applicant_id = #{hiring_stage.applicant.id} AND position_id = #{hiring_stage.position.id} AND vetting_stage_id = #{hiring_stage.vetting_stage.id}" ) + end + + # ------------------------------------------------------------ Instance Methods ------------------------------------------------------------ # app/models/vote.rb @@ -13,7 +13,7 @@ </td> <td class="t l" width="50%"> - <%= truncate( sanitize( applicant.contact_info ), 128 ) %> <br /> + <%= auto_link( truncate( sanitize( applicant.contact_info ), 128 ) ) %> <br /> <span class="small"><%= "Positions: " + applicant.positions.map { |pos| link_to( pos.title, position_path( pos ) ) }.to_sentence if ( applicant.positions.count > 0 ) %></span> </td> <td class="t c"> app/views/applicants/index.html.erb @@ -4,7 +4,7 @@ <table class="wide"> <tr> - <th><%= rounded_rect_box( "Title" ) %></th><th><%= rounded_rect_box( "Description" ) %></th><th><%= rounded_rect_box( "\# Applicants" ) %></th><th><%= rounded_rect_box( "Reviewers" ) %></th><th></th> + <th><%= rounded_rect_box( "Title" ) %></th><th><%= rounded_rect_box( "Description" ) %></th><th><%= rounded_rect_box( "Applicants" ) %></th><th><%= rounded_rect_box( "Reviewers" ) %></th><th></th> </tr> <% for position in @positions %> app/views/positions/index.html.erb @@ -11,7 +11,7 @@ <div id="wide_left"> <h2><%= image_tag "position.png" %> <%= @position.id %>: <%= @position.title %> <span class="default_font">for <%= @position.department.name if @position.department %>.</span></h2> - <div class="small">Posted by <%= link_to( @position.user.display_name, user_path( @position.user ) ) %> <span class="display_date"><%= @position.updated_at.friendly_date %></span></div> + <div class="small">Posted by <%= link_to( @position.user.display_name, user_path( @position.user ) ) %> <span class="display_date"><%= @position.created_at.friendly_date %></span></div> <% if @position.is_closed %> <h4 class="sub_header">This position is closed.</h4> app/views/positions/show.html.erb @@ -4,7 +4,7 @@ SITE_NAME = APPLICATION_NAME SITE_TAGLINE = "Are they an applican or an applican't?" -# ------------------------------ User Bar ------------------------------ # +# ------------------------------ Strings: User Bar ------------------------------ # ADMIN_SETTINGS_LINK = "admin" DEPARTMENTS_LINK = "departments" @@ -18,7 +18,7 @@ STAGES_LINK = "stages" USERS_LINK = "users" -# ------------------------------ Everywhere Else ------------------------------ # +# ------------------------------ Strings: Everywhere Else ------------------------------ # ADDED_ON = "Added on" @@ -38,4 +38,10 @@ POSITIONS_APPLIED_FOR = "Positions Applied For" RESUME = "Resume (CV)" SEARCH = "Search" USERNAME = "Username" -WELCOME_MESSAGE = "Welcome to Applican. Please log in." \ No newline at end of file +WELCOME_MESSAGE = "" + + +# ------------------------------ Numeric ------------------------------ # + + +CONSENSUS_PERCENTAGE = 1.00 \ No newline at end of file config/initializers/global_variables.rb 0d01969685a355249d502505398c8a10f5dde918 Chris chris@ChoOyu.local http://github.com/senorprogrammer/applican/commit/66b7447aec45321eba490c998b9a33911c0aa61a 66b7447aec45321eba490c998b9a33911c0aa61a 2008-07-04T14:44:26-07:00 2008-07-04T14:44:26-07:00 Voting an applicant now moves the applicant foward in the vetting stages if the minimum concensus value is reached (defaults to 1.0, ie: unanimous) bb08135707f2032128e041c90334914655b6f066 Chris chris@ChoOyu.local