From 238e9ca2fb22641e123855de74a44f10ce4e2256 Mon Sep 17 00:00:00 2001 From: Boris Chiou Date: Wed, 22 Jan 2020 20:18:31 +0000 Subject: [PATCH] style: Use Serde for rotate, scale, and translate properties. The only drawback is: we resolve LengthPercentage value before passing translate property through IPC, so its percentage part is redundant. However, this makes us easier to maintain the Rust type. Differential Revision: https://phabricator.services.mozilla.com/D60044 --- components/style/values/generics/transform.rs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/components/style/values/generics/transform.rs b/components/style/values/generics/transform.rs index 3322323e76e5..d452b215c6a5 100644 --- a/components/style/values/generics/transform.rs +++ b/components/style/values/generics/transform.rs @@ -611,8 +611,10 @@ pub fn get_normalized_vector_and_angle( Clone, Copy, Debug, + Deserialize, MallocSizeOf, PartialEq, + Serialize, SpecifiedValueInfo, ToAnimatedZero, ToComputedValue, @@ -623,6 +625,7 @@ pub fn get_normalized_vector_and_angle( /// A value of the `Rotate` property /// /// +/// cbindgen:private-default-tagged-enum-constructor=false pub enum GenericRotate { /// 'none' None, @@ -685,8 +688,10 @@ where Clone, Copy, Debug, + Deserialize, MallocSizeOf, PartialEq, + Serialize, SpecifiedValueInfo, ToAnimatedZero, ToComputedValue, @@ -697,6 +702,7 @@ where /// A value of the `Scale` property /// /// +/// cbindgen:private-default-tagged-enum-constructor=false pub enum GenericScale { /// 'none' None, @@ -749,8 +755,10 @@ fn y_axis_and_z_axis_are_zero( #[derive( Clone, Debug, + Deserialize, MallocSizeOf, PartialEq, + Serialize, SpecifiedValueInfo, ToAnimatedZero, ToComputedValue, @@ -772,6 +780,7 @@ fn y_axis_and_z_axis_are_zero( /// https://github.com/w3c/csswg-drafts/issues/3305 /// /// +/// cbindgen:private-default-tagged-enum-constructor=false pub enum GenericTranslate where LengthPercentage: Zero,