From 38d3f591706afe1dbd9fdfeacb50c8948fbe9925 Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Tue, 25 Sep 2018 15:20:23 -0400 Subject: [PATCH] Add useful logging defaults for debugging web content on android. --- ports/libsimpleservo/src/jniapi.rs | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/ports/libsimpleservo/src/jniapi.rs b/ports/libsimpleservo/src/jniapi.rs index 5c84b47ea8d5..8b5c9d7f0aea 100644 --- a/ports/libsimpleservo/src/jniapi.rs +++ b/ports/libsimpleservo/src/jniapi.rs @@ -64,11 +64,19 @@ pub fn Java_com_mozilla_servoview_JNIServo_init( // Note: Android debug logs are stripped from a release build. // debug!() will only show in a debug build. Use info!() if logs // should show up in adb logcat with a release build. - let mut filter = Filter::default() - .with_min_level(Level::Debug) - .with_allowed_module_path("simpleservo::api") - .with_allowed_module_path("simpleservo::jniapi") - .with_allowed_module_path("simpleservo::gl_glue::egl"); + let filters = [ + "simpleservo::api", + "simpleservo::jniapi", + "simpleservo::gl_glue::egl", + // Show JS errors by default. + "script::dom::bindings::error", + // Show GL errors by default. + "canvas::webgl_thread", + ]; + let mut filter = Filter::default().with_min_level(Level::Debug); + for &module in &filters { + filter = filter.with_allowed_module_path(module); + } let log_str = env.get_string(log_str).ok(); let log_str = log_str.as_ref().map_or(Cow::Borrowed(""), |s| s.to_string_lossy()); for module in log_str.split(',') {