From 3953456b619621983e1cb1af46beb80411981ffa Mon Sep 17 00:00:00 2001 From: Cameron Zwarich Date: Sat, 27 Sep 2014 20:43:39 -0700 Subject: [PATCH] Convert a method from &JSRef to JSRef This also removes the unnecessary formation of a trait object. --- components/script/dom/element.rs | 6 +++--- components/script/dom/node.rs | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index bf5f9014fd23..c734ad89161b 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -238,7 +238,7 @@ impl LayoutElementHelpers for JS { } pub trait ElementHelpers { - fn html_element_in_html_document(&self) -> bool; + fn html_element_in_html_document(self) -> bool; fn get_local_name<'a>(&'a self) -> &'a Atom; fn get_namespace<'a>(&'a self) -> &'a Namespace; fn summarize(self) -> Vec; @@ -246,8 +246,8 @@ pub trait ElementHelpers { } impl<'a> ElementHelpers for JSRef<'a, Element> { - fn html_element_in_html_document(&self) -> bool { - let node: JSRef = NodeCast::from_ref(*self); + fn html_element_in_html_document(self) -> bool { + let node: JSRef = NodeCast::from_ref(self); self.namespace == ns!(HTML) && node.is_in_html_doc() } diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs index b62225314e23..85f7f27bc1c9 100644 --- a/components/script/dom/node.rs +++ b/components/script/dom/node.rs @@ -2086,8 +2086,7 @@ impl<'a> style::TNode<'a, JSRef<'a, Element>> for JSRef<'a, Node> { fn is_html_element_in_html_document(&self) -> bool { let elem: Option> = ElementCast::to_ref(*self); assert!(elem.is_some()); - let elem: &ElementHelpers = &elem.unwrap() as &ElementHelpers; - elem.html_element_in_html_document() + elem.unwrap().html_element_in_html_document() } }