From 5230ad2c61cec18034bb58a8745b7f330f2049da Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Wed, 8 Feb 2017 12:39:38 +0100 Subject: [PATCH] Remove typeNeedsRooting(). It is only used once, in a case where it can never have an effect: in case for it to do something, both returnType.isDictionary() and returnType.isGeckoInterface() would need to be true at the same time. --- components/script/dom/bindings/codegen/CodegenRust.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index 9e96c932f489..b46d44c5982d 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -548,11 +548,6 @@ def typeIsSequenceOrHasSequenceMember(type): return False -def typeNeedsRooting(type, descriptorProvider): - return (type.isGeckoInterface() and - descriptorProvider.getDescriptor(type.unroll().inner.identifier.name).needsRooting) - - def union_native_type(t): name = t.unroll().name return 'UnionTypes::%s' % name @@ -1422,8 +1417,6 @@ def getRetvalDeclarationForType(returnType, descriptorProvider): nullable = returnType.nullable() dictName = returnType.inner.name if nullable else returnType.name result = CGGeneric(dictName) - if typeNeedsRooting(returnType, descriptorProvider): - raise TypeError("We don't support rootable dictionaries return values") if nullable: result = CGWrapper(result, pre="Option<", post=">") return result