From 75d258f86637a30522dd5e09e9d9f1a080f8b036 Mon Sep 17 00:00:00 2001 From: Joshua Holmer Date: Fri, 22 Jan 2016 10:12:16 -0500 Subject: [PATCH] Update HTMLFormElement.length to be of type unsigned long Fixes #9402 --- components/script/dom/htmlformelement.rs | 4 ++-- components/script/dom/webidls/HTMLFormElement.webidl | 2 +- tests/wpt/web-platform-tests/html/dom/interfaces.html | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/components/script/dom/htmlformelement.rs b/components/script/dom/htmlformelement.rs index 0922902778ae..32838399a937 100644 --- a/components/script/dom/htmlformelement.rs +++ b/components/script/dom/htmlformelement.rs @@ -205,8 +205,8 @@ impl HTMLFormElementMethods for HTMLFormElement { } // https://html.spec.whatwg.org/multipage/#dom-form-length - fn Length(&self) -> i32 { - self.Elements().Length() as i32 + fn Length(&self) -> u32 { + self.Elements().Length() as u32 } } diff --git a/components/script/dom/webidls/HTMLFormElement.webidl b/components/script/dom/webidls/HTMLFormElement.webidl index d97de7dd22d2..eebe0b52c62b 100644 --- a/components/script/dom/webidls/HTMLFormElement.webidl +++ b/components/script/dom/webidls/HTMLFormElement.webidl @@ -17,7 +17,7 @@ interface HTMLFormElement : HTMLElement { attribute DOMString target; [SameObject] readonly attribute HTMLFormControlsCollection elements; - readonly attribute long length; + readonly attribute unsigned long length; //getter Element (unsigned long index); //getter (RadioNodeList or Element) (DOMString name); diff --git a/tests/wpt/web-platform-tests/html/dom/interfaces.html b/tests/wpt/web-platform-tests/html/dom/interfaces.html index f76d0ce38a70..8eb7df805fb6 100644 --- a/tests/wpt/web-platform-tests/html/dom/interfaces.html +++ b/tests/wpt/web-platform-tests/html/dom/interfaces.html @@ -1591,7 +1591,7 @@

HTML IDL tests

attribute DOMString target; readonly attribute HTMLFormControlsCollection elements; - readonly attribute long length; + readonly attribute unsigned long length; getter Element (unsigned long index); getter (RadioNodeList or Element) (DOMString name);