From 8679bafa93d5f87703c4aa1d2e461c9ae71bea35 Mon Sep 17 00:00:00 2001 From: Gecko Backout Date: Sun, 26 Nov 2017 11:02:41 +0000 Subject: [PATCH] Backed out changeset 077ce85c466b for failing devtools webconsole/test/browser_webconsole_bug_595934_message_categories.js on Windows 7 debug without e10s. r=backout on a CLOSED TREE Backs out https://github.com/servo/servo/pull/19374 --- components/style/gecko/generated/bindings.rs | 4 ++-- ports/geckolib/glue.rs | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/components/style/gecko/generated/bindings.rs b/components/style/gecko/generated/bindings.rs index aa320c6a4953..1e09fa42baf4 100644 --- a/components/style/gecko/generated/bindings.rs +++ b/components/style/gecko/generated/bindings.rs @@ -1574,7 +1574,7 @@ extern "C" { } extern "C" { pub fn Servo_IsValidCSSColor ( value : * const nsAString , ) -> bool ; } extern "C" { - pub fn Servo_ComputeColor ( set : RawServoStyleSetBorrowedOrNull , current_color : nscolor , value : * const nsAString , result_color : * mut nscolor , was_current_color : * mut bool , ) -> bool ; + pub fn Servo_ComputeColor ( set : RawServoStyleSetBorrowedOrNull , current_color : nscolor , value : * const nsAString , result_color : * mut nscolor , ) -> bool ; } extern "C" { pub fn Servo_ParseIntersectionObserverRootMargin ( value : * const nsAString , result : * mut nsCSSRect , ) -> bool ; } extern "C" { @@ -1587,4 +1587,4 @@ extern "C" { pub fn Gecko_ContentList_AppendAll ( aContentList : * mut nsSimpleContentList , aElements : * mut * const RawGeckoElement , aLength : usize , ) ; } extern "C" { pub fn Gecko_GetElementsWithId ( aDocument : * const nsIDocument , aId : * mut nsAtom , ) -> * const nsTArray < * mut Element > ; -} +} \ No newline at end of file diff --git a/ports/geckolib/glue.rs b/ports/geckolib/glue.rs index f7733b37516f..c0b60adaad50 100644 --- a/ports/geckolib/glue.rs +++ b/ports/geckolib/glue.rs @@ -4559,7 +4559,6 @@ pub extern "C" fn Servo_ComputeColor( current_color: structs::nscolor, value: *const nsAString, result_color: *mut structs::nscolor, - was_current_color: *mut bool, ) -> bool { use style::gecko; @@ -4594,11 +4593,6 @@ pub extern "C" fn Servo_ComputeColor( Some(computed_color) => { let rgba = computed_color.to_rgba(current_color); *result_color = gecko::values::convert_rgba_to_nscolor(&rgba); - if !was_current_color.is_null() { - unsafe { - *was_current_color = computed_color.is_currentcolor(); - } - } true } None => false,