From 94ce09763e5100b89169998f89e57895ef994537 Mon Sep 17 00:00:00 2001 From: Cameron McCormack Date: Thu, 26 May 2016 15:50:34 +1000 Subject: [PATCH] Don't re-parse dummy base URL every time in GeckoElement::style_attribute. --- ports/geckolib/wrapper.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ports/geckolib/wrapper.rs b/ports/geckolib/wrapper.rs index a30060d416ae..28ec1f30720e 100644 --- a/ports/geckolib/wrapper.rs +++ b/ports/geckolib/wrapper.rs @@ -314,6 +314,12 @@ impl<'le> GeckoElement<'le> { } } +lazy_static! { + pub static ref DUMMY_BASE_URL: Url = { + Url::parse("http://www.example.org").unwrap() + }; +} + impl<'le> TElement for GeckoElement<'le> { type ConcreteNode = GeckoNode<'le>; type ConcreteDocument = GeckoDocument<'le>; @@ -330,7 +336,7 @@ impl<'le> TElement for GeckoElement<'le> { // in the nsAttrValue. That will allow us to borrow it from here. let attr = self.get_attr(&ns!(), &atom!("style")); // FIXME(bholley): Real base URL and error reporter. - let base_url = Url::parse("http://www.example.org").unwrap(); + let base_url = &*DUMMY_BASE_URL; // FIXME(heycam): Needs real ParserContextExtraData so that URLs parse // properly. let extra_data = ParserContextExtraData::default();