diff --git a/components/layout/fragment.rs b/components/layout/fragment.rs index bfef94fdd0d8..dbf6307bac1d 100644 --- a/components/layout/fragment.rs +++ b/components/layout/fragment.rs @@ -2008,10 +2008,8 @@ impl Fragment { let font_derived_metrics = InlineMetrics::from_font_metrics(&info.run.font_metrics, line_height); InlineMetrics { - block_size_above_baseline: font_derived_metrics.block_size_above_baseline + - self.border_padding.block_start, - depth_below_baseline: font_derived_metrics.depth_below_baseline + - self.border_padding.block_end, + block_size_above_baseline: font_derived_metrics.block_size_above_baseline, + depth_below_baseline: font_derived_metrics.depth_below_baseline, ascent: font_derived_metrics.ascent + self.border_padding.block_start, } } diff --git a/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-001.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-001.htm.ini deleted file mode 100644 index 92b2edb5116e..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-001.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[border-padding-bleed-001.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-002.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-002.htm.ini deleted file mode 100644 index eafdcac72f7e..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-002.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[border-padding-bleed-002.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-003.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-003.htm.ini deleted file mode 100644 index 3a35dffe436c..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/border-padding-bleed-003.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[border-padding-bleed-003.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/border-width-applies-to-008.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/border-width-applies-to-008.htm.ini deleted file mode 100644 index d6a60adec458..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/border-width-applies-to-008.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[border-width-applies-to-008.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/c5506-ipadn-t-000.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/c5506-ipadn-t-000.htm.ini deleted file mode 100644 index 51e0ddd40559..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/c5506-ipadn-t-000.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[c5506-ipadn-t-000.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/c5506-ipadn-t-002.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/c5506-ipadn-t-002.htm.ini deleted file mode 100644 index 2942e9f5c432..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/c5506-ipadn-t-002.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[c5506-ipadn-t-002.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/c5508-ipadn-b-000.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/c5508-ipadn-b-000.htm.ini deleted file mode 100644 index 661978ebe572..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/c5508-ipadn-b-000.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[c5508-ipadn-b-000.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/c5510-ipadn-000.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/c5510-ipadn-000.htm.ini index 8973408f5997..5eabcb65ce27 100644 --- a/tests/wpt/metadata-css/css21_dev/html4/c5510-ipadn-000.htm.ini +++ b/tests/wpt/metadata-css/css21_dev/html4/c5510-ipadn-000.htm.ini @@ -1,3 +1,4 @@ [c5510-ipadn-000.htm] type: reftest - expected: FAIL + expected: + if os != "mac": FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/inline-formatting-context-022.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/inline-formatting-context-022.htm.ini deleted file mode 100644 index 78d873ffa948..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/inline-formatting-context-022.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[inline-formatting-context-022.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/inline-formatting-context-023.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/inline-formatting-context-023.htm.ini deleted file mode 100644 index 8f3fd2946a61..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/inline-formatting-context-023.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[inline-formatting-context-023.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/inline-non-replaced-height-002.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/inline-non-replaced-height-002.htm.ini deleted file mode 100644 index b31af8d4e114..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/inline-non-replaced-height-002.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[inline-non-replaced-height-002.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/inline-non-replaced-height-003.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/inline-non-replaced-height-003.htm.ini deleted file mode 100644 index 346df502fca5..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/inline-non-replaced-height-003.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[inline-non-replaced-height-003.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/margin-bottom-applies-to-008.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/margin-bottom-applies-to-008.htm.ini deleted file mode 100644 index fb3d1d08ba9e..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/margin-bottom-applies-to-008.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[margin-bottom-applies-to-008.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/metadata-css/css21_dev/html4/margin-top-applies-to-008.htm.ini b/tests/wpt/metadata-css/css21_dev/html4/margin-top-applies-to-008.htm.ini deleted file mode 100644 index aa17dcc51c03..000000000000 --- a/tests/wpt/metadata-css/css21_dev/html4/margin-top-applies-to-008.htm.ini +++ /dev/null @@ -1,3 +0,0 @@ -[margin-top-applies-to-008.htm] - type: reftest - expected: FAIL diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json index 84e624262c31..ee90a1be5d40 100644 --- a/tests/wpt/mozilla/meta/MANIFEST.json +++ b/tests/wpt/mozilla/meta/MANIFEST.json @@ -2616,6 +2616,18 @@ "url": "/_mozilla/css/inline_element_border_a.html" } ], + "css/inline_element_padding_margin.html": [ + { + "path": "css/inline_element_padding_margin.html", + "references": [ + [ + "/_mozilla/css/inline_element_padding_margin_ref.html", + "==" + ] + ], + "url": "/_mozilla/css/inline_element_padding_margin.html" + } + ], "css/inline_font_size_zero_a.html": [ { "path": "css/inline_font_size_zero_a.html", @@ -11872,6 +11884,18 @@ "url": "/_mozilla/css/inline_element_border_a.html" } ], + "css/inline_element_padding_margin.html": [ + { + "path": "css/inline_element_padding_margin.html", + "references": [ + [ + "/_mozilla/css/inline_element_padding_margin_ref.html", + "==" + ] + ], + "url": "/_mozilla/css/inline_element_padding_margin.html" + } + ], "css/inline_font_size_zero_a.html": [ { "path": "css/inline_font_size_zero_a.html", diff --git a/tests/wpt/mozilla/tests/css/inline_element_padding_margin.html b/tests/wpt/mozilla/tests/css/inline_element_padding_margin.html new file mode 100644 index 000000000000..014a76299b24 --- /dev/null +++ b/tests/wpt/mozilla/tests/css/inline_element_padding_margin.html @@ -0,0 +1,21 @@ + + + + + Border, padding and margin properties' top and bottom values of inline elements shouldn't affect element's height + + + + + foo +
+ bar + + diff --git a/tests/wpt/mozilla/tests/css/inline_element_padding_margin_ref.html b/tests/wpt/mozilla/tests/css/inline_element_padding_margin_ref.html new file mode 100644 index 000000000000..1b37ddc8575b --- /dev/null +++ b/tests/wpt/mozilla/tests/css/inline_element_padding_margin_ref.html @@ -0,0 +1,12 @@ + + + + + Border, padding and margin properties' top and bottom values of inline elements shouldn't affect element's height + + + foo +
+ bar + +