From b20881639e1e0b55500b90babc1ac7a8bdf1f32d Mon Sep 17 00:00:00 2001 From: Patrick Shaughnessy Date: Tue, 31 Dec 2019 17:57:59 -0500 Subject: [PATCH] Radio button grouping is now case-sensitive --- components/script/dom/htmlinputelement.rs | 3 +-- .../radio-groupname-case.html.ini | 26 ------------------- 2 files changed, 1 insertion(+), 28 deletions(-) delete mode 100644 tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs index 9018f05813af..0cef0a105358 100755 --- a/components/script/dom/htmlinputelement.rs +++ b/components/script/dom/htmlinputelement.rs @@ -46,7 +46,6 @@ use crate::textinput::KeyReaction::{ }; use crate::textinput::Lines::Single; use crate::textinput::{Direction, SelectionDirection, TextInput, UTF16CodeUnits, UTF8Bytes}; -use caseless::compatibility_caseless_match_str; use dom_struct::dom_struct; use embedder_traits::FilterPattern; use encoding_rs::Encoding; @@ -917,7 +916,7 @@ fn in_same_group( // TODO Both a and b are in the same home subtree. other.form_owner().as_deref() == owner && match (other.radio_group_name(), group) { - (Some(ref s1), Some(s2)) => compatibility_caseless_match_str(s1, s2) && s2 != &atom!(""), + (Some(ref s1), Some(s2)) => s1 == s2 && s2 != &atom!(""), _ => false } } diff --git a/tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini b/tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini deleted file mode 100644 index 69e88a9bd4ed..000000000000 --- a/tests/wpt/metadata/html/semantics/forms/the-input-element/radio-groupname-case.html.ini +++ /dev/null @@ -1,26 +0,0 @@ -[radio-groupname-case.html] - type: testharness - [radio button group name = paSSfield-killroyß] - expected: FAIL - - [Among names like sImPlE, everything must be checkable at the same time] - expected: FAIL - - [Among names like paSSfield-killroyß, everything must be checkable at the same time] - expected: FAIL - - [Among names like глупый, everything must be checkable at the same time] - expected: FAIL - - [Among names like åωk, everything must be checkable at the same time] - expected: FAIL - - [Among names like blah1, everything must be checkable at the same time] - expected: FAIL - - [Among names like tÉdz5アパートFi, everything must be checkable at the same time] - expected: FAIL - - [Among names like ΣΣ, everything must be checkable at the same time] - expected: FAIL -