From c13ea8a2530fa892b085c16894de5c2789c94863 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Naz=C4=B1m=20Can=20Alt=C4=B1nova?= Date: Tue, 29 Mar 2016 02:22:01 +0300 Subject: [PATCH] Make input elements not inherit parent containers alignment Added a reftest for input element's alignment Added float: left beacause text-align: center centers the input's itself. Removed 'rtl' alignment --- resources/servo.css | 2 +- tests/wpt/mozilla/meta/MANIFEST.json | 24 +++++++++++++++++++ .../mozilla/tests/css/input_alignment_a.html | 16 +++++++++++++ .../tests/css/input_alignment_ref.html | 12 ++++++++++ 4 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 tests/wpt/mozilla/tests/css/input_alignment_a.html create mode 100644 tests/wpt/mozilla/tests/css/input_alignment_ref.html diff --git a/resources/servo.css b/resources/servo.css index 5f0bcdf695fd..73d621a75738 100644 --- a/resources/servo.css +++ b/resources/servo.css @@ -1,4 +1,4 @@ -input { background: white; min-height: 1.0em; padding: 0em; padding-left: 0.25em; padding-right: 0.25em; border: solid lightgrey 1px; color: black; white-space: nowrap; } +input { background: white; min-height: 1.0em; padding: 0em; padding-left: 0.25em; padding-right: 0.25em; border: solid lightgrey 1px; color: black; white-space: nowrap; text-align: left; } textarea { background: white; min-height: 1.0em; padding: 0em; padding-left: 0.25em; padding-right: 0.25em; border: solid lightgrey 1px; color: black; white-space: pre; } button, input[type="button"], diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json index 947e3ae93a5f..00f6a65459cc 100644 --- a/tests/wpt/mozilla/meta/MANIFEST.json +++ b/tests/wpt/mozilla/meta/MANIFEST.json @@ -2480,6 +2480,18 @@ "url": "/_mozilla/css/inline_whitespace_b.html" } ], + "css/input_alignment_a.html": [ + { + "path": "css/input_alignment_a.html", + "references": [ + [ + "/_mozilla/css/input_alignment_ref.html", + "==" + ] + ], + "url": "/_mozilla/css/input_alignment_a.html" + } + ], "css/input_button_margins_a.html": [ { "path": "css/input_button_margins_a.html", @@ -8818,6 +8830,18 @@ "url": "/_mozilla/css/inline_whitespace_b.html" } ], + "css/input_alignment_a.html": [ + { + "path": "css/input_alignment_a.html", + "references": [ + [ + "/_mozilla/css/input_alignment_ref.html", + "==" + ] + ], + "url": "/_mozilla/css/input_alignment_a.html" + } + ], "css/input_button_margins_a.html": [ { "path": "css/input_button_margins_a.html", diff --git a/tests/wpt/mozilla/tests/css/input_alignment_a.html b/tests/wpt/mozilla/tests/css/input_alignment_a.html new file mode 100644 index 000000000000..9a2262e3b476 --- /dev/null +++ b/tests/wpt/mozilla/tests/css/input_alignment_a.html @@ -0,0 +1,16 @@ + + + + Input elements shouldn't inherit parent containers alignment + + + + +
+ + \ No newline at end of file diff --git a/tests/wpt/mozilla/tests/css/input_alignment_ref.html b/tests/wpt/mozilla/tests/css/input_alignment_ref.html new file mode 100644 index 000000000000..7c845c6d31ab --- /dev/null +++ b/tests/wpt/mozilla/tests/css/input_alignment_ref.html @@ -0,0 +1,12 @@ + + + + Input elements shouldn't inherit parent containers alignment + + + +
+ + \ No newline at end of file