From e18a3ad841b457ffe79c210dab3b73561ff5d3d0 Mon Sep 17 00:00:00 2001 From: Bastien Orivel Date: Tue, 5 May 2020 23:45:54 +0200 Subject: [PATCH] Separate values in Headers with ", ", not "," Tests expect header values to be separated by that so this fixes a few of them. --- components/script/dom/headers.rs | 2 +- .../fetch/api/headers/headers-combine.html.ini | 14 -------------- 2 files changed, 1 insertion(+), 15 deletions(-) delete mode 100644 tests/wpt/metadata/fetch/api/headers/headers-combine.html.ini diff --git a/components/script/dom/headers.rs b/components/script/dom/headers.rs index c8d0f79fc826..ff4fb39aec83 100644 --- a/components/script/dom/headers.rs +++ b/components/script/dom/headers.rs @@ -96,7 +96,7 @@ impl HeadersMethods for Headers { .get(HeaderName::from_str(&valid_name).unwrap()) { combined_value = v.as_bytes().to_vec(); - combined_value.push(b','); + combined_value.extend(b", "); } combined_value.extend(valid_value.iter().cloned()); match HeaderValue::from_bytes(&combined_value) { diff --git a/tests/wpt/metadata/fetch/api/headers/headers-combine.html.ini b/tests/wpt/metadata/fetch/api/headers/headers-combine.html.ini deleted file mode 100644 index 3ecf3b576f75..000000000000 --- a/tests/wpt/metadata/fetch/api/headers/headers-combine.html.ini +++ /dev/null @@ -1,14 +0,0 @@ -[headers-combine.html] - type: testharness - [Create headers using same name for different values] - expected: FAIL - - [Check append methods when called with already used name] - expected: FAIL - - [Iterate combined values] - expected: FAIL - - [Iterate combined values in sorted order] - expected: FAIL -