From ff6dc856e690d9be3f34ffbc512b44c9cc100d3d Mon Sep 17 00:00:00 2001 From: Paul Rouget Date: Tue, 11 Jul 2017 08:19:47 +0200 Subject: [PATCH] remove no-op InitializeCompositing message --- components/compositing/compositor.rs | 7 ------- components/compositing/windowing.rs | 4 ---- ports/cef/browser_host.rs | 3 +-- ports/servo/main.rs | 2 -- 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/components/compositing/compositor.rs b/components/compositing/compositor.rs index 337bf23a4115..9640f05bd899 100644 --- a/components/compositing/compositor.rs +++ b/components/compositing/compositor.rs @@ -742,10 +742,6 @@ impl IOCompositor { self.composite(); } - WindowEvent::InitializeCompositing => { - self.initialize_compositing(); - } - WindowEvent::Resize(size) => { self.on_resize_window_event(size); } @@ -1566,9 +1562,6 @@ impl IOCompositor { } } - fn initialize_compositing(&mut self) { - } - fn get_root_pipeline_id(&self) -> Option { self.root_pipeline.as_ref().map(|pipeline| pipeline.id) } diff --git a/components/compositing/windowing.rs b/components/compositing/windowing.rs index 94dfca5268ee..9896cf4aab11 100644 --- a/components/compositing/windowing.rs +++ b/components/compositing/windowing.rs @@ -44,9 +44,6 @@ pub enum WindowEvent { /// Sent when part of the window is marked dirty and needs to be redrawn. Before sending this /// message, the window must make the same GL context as in `PrepareRenderingEvent` current. Refresh, - /// Sent to initialize the GL context. The windowing system must have a valid, current GL - /// context when this message is sent. - InitializeCompositing, /// Sent when the window is resized. Resize(TypedSize2D), /// Touchpad Pressure @@ -85,7 +82,6 @@ impl Debug for WindowEvent { match *self { WindowEvent::Idle => write!(f, "Idle"), WindowEvent::Refresh => write!(f, "Refresh"), - WindowEvent::InitializeCompositing => write!(f, "InitializeCompositing"), WindowEvent::Resize(..) => write!(f, "Resize"), WindowEvent::TouchpadPressure(..) => write!(f, "TouchpadPressure"), WindowEvent::KeyEvent(..) => write!(f, "Key"), diff --git a/ports/cef/browser_host.rs b/ports/cef/browser_host.rs index 608ccfbad709..3a7913d6fb11 100644 --- a/ports/cef/browser_host.rs +++ b/ports/cef/browser_host.rs @@ -486,8 +486,7 @@ full_cef_class_impl! { this.downcast().send_window_event(WindowEvent::PinchZoom((new_zoom_level / old_zoom_level) as f32)) }} - fn initialize_compositing(&this,) -> () {{ - this.downcast().send_window_event(WindowEvent::InitializeCompositing); + fn initialize_compositing(&_this,) -> () {{ }} fn composite(&this,) -> () {{ diff --git a/ports/servo/main.rs b/ports/servo/main.rs index a812e50ecf84..ff99c9c5afaa 100644 --- a/ports/servo/main.rs +++ b/ports/servo/main.rs @@ -165,8 +165,6 @@ fn main() { register_glutin_resize_handler(&window, &mut browser); - browser.browser.handle_events(vec![WindowEvent::InitializeCompositing]); - // Feed events from the window to the browser until the browser // says to stop. loop {