Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that gradients have at least 2 stops #15323

Merged
merged 1 commit into from Feb 1, 2017
Merged

Ensure that gradients have at least 2 stops #15323

merged 1 commit into from Feb 1, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Feb 1, 2017 •
edited by larsbergstrom

@highfive
Copy link

highfive commented Feb 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/image.rs
  • @emilio: components/style/values/specified/image.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2017
@highfive
Copy link

highfive commented Feb 1, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@Manishearth
Copy link
Member Author

@bors-servo try

should be csstests for this

@bors-servo
Copy link
Contributor

⌛ Trying commit c0e1a1f with merge 9a89eb8...

bors-servo pushed a commit that referenced this pull request Feb 1, 2017
Auto merge of #15323 - Manishearth:gradient-stop, r=<try>
9a89eb8 
Ensure that gradients have at least 2 stops

fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1335656

r? @heycam
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@Manishearth
Copy link
Member Author

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit c0e1a1f has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 1, 2017
@Manishearth
Copy link
Member Author

@bors-servo try- retry

@bors-servo
Copy link
Contributor

⌛ Testing commit c0e1a1f with merge b7887a1...

bors-servo pushed a commit that referenced this pull request Feb 1, 2017
Auto merge of #15323 - Manishearth:gradient-stop, r=heycam
b7887a1 
Ensure that gradients have at least 2 stops

fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1335656

r? @heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15323)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@bors-servo bors-servo merged commit c0e1a1f into servo:master Feb 1, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 1, 2017
@Manishearth Manishearth deleted the gradient-stop branch February 1, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heycam heycam heycam approved these changes

Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Manishearth @highfive @bors-servo @heycam