Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some enhancements in the net crate #16160

Merged
merged 4 commits into from Mar 29, 2017
Merged

Some enhancements in the net crate #16160

merged 4 commits into from Mar 29, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Mar 27, 2017 •
edited by larsbergstrom

See the individual commits.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net/fetch/methods.rs, components/net/connector.rs, components/net/http_loader.rs

@highfive
Copy link

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 27, 2017
@nox
Copy link
Contributor Author

nox commented Mar 27, 2017

r? @jdm

@highfive highfive assigned jdm and unassigned cbrewster Mar 27, 2017
@jdm
Copy link
Member

jdm commented Mar 28, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 02b2aa1 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 28, 2017
@nox
Copy link
Contributor Author

nox commented Mar 28, 2017

@bors-servo retry force

@nox nox closed this Mar 28, 2017
@nox nox reopened this Mar 28, 2017
@nox
Copy link
Contributor Author

nox commented Mar 28, 2017

@bors-servo retry clean force

@Manishearth
Copy link
Member

@bors-servo are you still there?

@bors-servo
Copy link
Contributor

🍰 Activated

@Manishearth
Copy link
Member

@bors-servo retry clean r- r=jdm

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit 02b2aa1 has been approved by jdm

@Manishearth
Copy link
Member

@bors-servo retry clean

1 similar comment
@Manishearth
Copy link
Member

@bors-servo retry clean

@Manishearth
Copy link
Member

@bors-servo r- r=jdm retry

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit 02b2aa1 has been approved by jdm

@nox
Copy link
Contributor Author

nox commented Mar 28, 2017

@bors-servo p=2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 28, 2017
@nox
Copy link
Contributor Author

nox commented Mar 28, 2017

@bors-servo retry #16172

@bors-servo
Copy link
Contributor

⌛ Testing commit 02b2aa1 with merge dbaa9e4...

bors-servo pushed a commit that referenced this pull request Mar 28, 2017
Auto merge of #16160 - nox:tungstenite, r=jdm
dbaa9e4 
Some enhancements in the net crate

See the individual commits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16160)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 28, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 28, 2017
@nox
Copy link
Contributor Author

nox commented Mar 28, 2017

@bors-servo retry #14323

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Mar 28, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 02b2aa1 with merge a9b7984f2b12fb78b1b100e8f858b3e9701a59ee...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 29, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 29, 2017
@nox
Copy link
Contributor Author

nox commented Mar 29, 2017

@bors-servo retry #14237

@bors-servo
Copy link
Contributor

⌛ Testing commit 02b2aa1 with merge 299f944...

bors-servo pushed a commit that referenced this pull request Mar 29, 2017
Auto merge of #16160 - nox:tungstenite, r=jdm
299f944 
Some enhancements in the net crate

See the individual commits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16160)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 29, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 299f944 to master...

@bors-servo bors-servo merged commit 02b2aa1 into servo:master Mar 29, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 29, 2017
@bors-servo bors-servo mentioned this pull request Mar 29, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nox @highfive @jdm @bors-servo @Manishearth @cbrewster