New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paint worklet size should agree with Chrome. #17456
Paint worklet size should agree with Chrome. #17456
Conversation
Heads up! This PR modifies the following files:
|
Spec issue: w3c/css-houdini-drafts#417 |
r? @emilio |
@@ -0,0 +1,3 @@ | |||
[test_paint_worklet_size.html] | |||
type: reftest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? Why expected fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paint rendering contexts haven't landed yet, that's #17326.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is complaining because it needs a manifest update, but with that, r=me
96edcd0
to
dded87e
Compare
Sigh, manifest errors. @bors-servo r=emilio |
📌 Commit dded87e has been approved by |
Paint worklet size should agree with Chrome. <!-- Please describe your changes on the following line: --> Getting our implementation to agree with Chrome about the definition of the size parameter to a paint worklet. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17376 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17456) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
Getting our implementation to agree with Chrome about the definition of the size parameter to a paint worklet.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is