Submit test-perf CSV files to S3 #19244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
r? @edunham |
|
The CSV files are generated by #19233. |
|
☔ The latest upstream changes (presumably #19233) made this pull request unmergeable. Please resolve the merge conflicts. |
asajeffrey
force-pushed
the
test-perf-submit-to-s3
branch
from
d0e5b05
to
3126fff
Compare
asajeffrey
force-pushed
the
test-perf-submit-to-s3
branch
from
3126fff
to
3e5c31e
Compare
|
☔ The latest upstream changes (presumably #19245) made this pull request unmergeable. Please resolve the merge conflicts. |
asajeffrey
force-pushed
the
test-perf-submit-to-s3
branch
from
3e5c31e
to
920ec6f
Compare
|
☔ The latest upstream changes (presumably #19305) made this pull request unmergeable. Please resolve the merge conflicts. |
asajeffrey
force-pushed
the
test-perf-submit-to-s3
branch
from
920ec6f
to
be5eaa4
Compare
|
cc @jdm |
4 tasks
|
@bors-servo: r+ |
|
📌 Commit be5eaa4 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Nov 21, 2017
Submit test-perf CSV files to S3 <!-- Please describe your changes on the following line: --> Submit CSV files to S3 rather than json files to Perfherder. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because this is test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19244) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit CSV files to S3 rather than json files to Perfherder.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is