Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test-perf on linux-nightly. #19323

Merged
merged 1 commit into from Nov 27, 2017

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Nov 21, 2017

Run test-perf on linux-nightly.



This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 21, 2017
@asajeffrey
Copy link
Member Author

r? @edunham cc @jdm

Once #19244 lands, this will get the test-perf CSVs in S3. We can then use something like Google Data Studio to generate reports, e.g. https://datastudio.google.com/open/1b16G5pQNp2lE-1nNcPlOure9G0eR36cq

screenshot from 2017-11-21 10-05-13

@highfive highfive assigned edunham and unassigned metajack Nov 21, 2017
@asajeffrey
Copy link
Member Author

ping?

@metajack
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 1a59ea9 has been approved by metajack

@highfive highfive assigned metajack and unassigned edunham Nov 27, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 27, 2017
@edunham
Copy link
Contributor

edunham commented Nov 27, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit 1a59ea9 has been approved by edunham

@highfive highfive assigned edunham and unassigned metajack Nov 27, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 1a59ea9 with merge 8b6b2e9...

bors-servo pushed a commit that referenced this pull request Nov 27, 2017
Run test-perf on linux-nightly.

<!-- Please describe your changes on the following line: -->

Run test-perf on linux-nightly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12988
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19323)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: edunham
Pushing 8b6b2e9 to master...

@bors-servo bors-servo merged commit 1a59ea9 into servo:master Nov 27, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run the page load performance test in CI
5 participants