Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload buildbot perf data to S3. #19450

Merged
merged 1 commit into from Dec 5, 2017
Merged

Upload buildbot perf data to S3. #19450

merged 1 commit into from Dec 5, 2017

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 1, 2017 •
edited by SimonSapin

Upload performance data to S3.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because this is test infrastructure

This change is Reviewable

@highfive
Copy link

highfive commented Dec 1, 2017

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/performance/download_buildbot_timings.py, etc/ci/buildbot_steps.yml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 1, 2017
@asajeffrey
Copy link
Member Author

r? @jdm

@highfive highfive assigned jdm and unassigned glennw Dec 1, 2017
@asajeffrey
Copy link
Member Author

Depends on servo/saltfs#760

@asajeffrey
Copy link
Member Author

We'd talked about putting this into ./mach upload-nightly, but the problem is that boto3 doesn't support the equivalent of aws s3 sync.

@jdm jdm added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 1, 2017
@asajeffrey
Copy link
Member Author

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

📌 Commit 524df9e has been approved by jdm

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 2, 2017
@asajeffrey asajeffrey removed the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Dec 2, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 524df9e with merge 4d2c6b7...

bors-servo pushed a commit that referenced this pull request Dec 2, 2017
Auto merge of #19450 - asajeffrey:buildbot-perf-upload-to-s3, r=jdm
4d2c6b7 
Upload buildbot perf data to S3.

<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19450)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 2, 2017
@asajeffrey
Copy link
Member Author

@bors-servo retry

Not sure what caused that test failure,

@bors-servo
Copy link
Contributor

⌛ Testing commit 524df9e with merge 8ea5249...

bors-servo pushed a commit that referenced this pull request Dec 4, 2017
Auto merge of #19450 - asajeffrey:buildbot-perf-upload-to-s3, r=jdm
8ea5249 
Upload buildbot perf data to S3.

<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19450)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 4, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt3

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 4, 2017
@asajeffrey
Copy link
Member Author

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 524df9e with merge ed03917...

bors-servo pushed a commit that referenced this pull request Dec 4, 2017
Auto merge of #19450 - asajeffrey:buildbot-perf-upload-to-s3, r=jdm
ed03917 
Upload buildbot perf data to S3.

<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19450)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 4, 2017
@bors-servo
Copy link
Contributor

⛄ The build was interrupted to prioritize another pull request.

@bors-servo
Copy link
Contributor

⌛ Testing commit 524df9e with merge 197aa9e...

bors-servo pushed a commit that referenced this pull request Dec 5, 2017
Auto merge of #19450 - asajeffrey:buildbot-perf-upload-to-s3, r=jdm
197aa9e 
Upload buildbot perf data to S3.

<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19450)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 5, 2017
@jdm
Copy link
Member

jdm commented Dec 5, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 524df9e with merge b56d7b8...

bors-servo pushed a commit that referenced this pull request Dec 5, 2017
Auto merge of #19450 - asajeffrey:buildbot-perf-upload-to-s3, r=jdm
b56d7b8 
Upload buildbot perf data to S3.

<!-- Please describe your changes on the following line: -->

Upload performance data to S3.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19450)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 5, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing b56d7b8 to master...

@bors-servo bors-servo merged commit 524df9e into servo:master Dec 5, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 5, 2017
@aneeshusa aneeshusa mentioned this pull request Dec 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

Assignees

@jdm jdm

Labels
A-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asajeffrey @highfive @bors-servo @jdm @glennw