Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EXT_shader_texture_lod #20915

Merged
merged 1 commit into from Jun 4, 2018
Merged

Implement EXT_shader_texture_lod #20915

merged 1 commit into from Jun 4, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Jun 4, 2018 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

highfive commented Jun 4, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/EXTShaderTextureLod.webidl, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs
  • @fitzgen: components/script/dom/webidls/EXTShaderTextureLod.webidl, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs
  • @KiChjang: components/script/dom/webidls/EXTShaderTextureLod.webidl, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 4, 2018
@jdm
Copy link
Member

jdm commented Jun 4, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 4e5e1e6 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 4, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 4e5e1e6 with merge 0b6df7e...

bors-servo pushed a commit that referenced this pull request Jun 4, 2018
Auto merge of #20915 - servo:webgl, r=jdm
0b6df7e 
Implement EXT_shader_texture_lod

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20915)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 4, 2018
@jdm
Copy link
Member

jdm commented Jun 4, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 0b6df7e to master...

@bors-servo bors-servo merged commit 4e5e1e6 into master Jun 4, 2018
@nox nox mentioned this pull request Jun 5, 2018
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nox @highfive @jdm @bors-servo