Updated mozjs_sys to v0.51.3 #21102
Merged
Updated mozjs_sys to v0.51.3 #21102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 4966c94 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 29, 2018
Updated mozjs_sys to v0.51.3 <!-- Please describe your changes on the following line: --> Allows building servo for target `i686-linux-android`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21093 - [X] These changes do not require tests because deperndency update <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21102) <!-- Reviewable:end -->
|
homu says this is pending but buildbot seems to have not be notified at all. @bors-servo r- |
SimonSapin
force-pushed
the
mozjs-sys-0.51.3
branch
from
4966c94
to
bf42577
Compare
highfive
added
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit bf42577 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo retry |
|
@bors-servo r- force clean |
|
@bors-servo r+ |
|
📌 Commit bf42577 has been approved by |
|
Hmm, even force cleaning it doesn't seem to have helped. |
bors-servo
pushed a commit
that referenced
this pull request
Jun 30, 2018
Updated mozjs_sys to v0.51.3 <!-- Please describe your changes on the following line: --> Allows building servo for target `i686-linux-android`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21093 - [X] These changes do not require tests because deperndency update <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21102) <!-- Reviewable:end -->
|
💔 Test failed - android |
highfive
added
S-tests-failed
|
@bors-servo retry |
|
⚡ Previous build results for linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only android, arm32, arm64, mac-rel-wpt2, mac-rel-wpt4... |
|
💔 Test failed - mac-rel-wpt4 |
|
@bors-servo retry |
|
⚡ Previous build results for linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only android, arm32, arm64, mac-rel-wpt4... |
SimonSapin
force-pushed
the
mozjs-sys-0.51.3
branch
from
bf42577
to
a557e2f
Compare
highfive
added
S-awaiting-review
|
Only the mac job ever started… Pushing yet another trivially-amended commit to try get homu/buildbot more into a known state. @bors-servo r+ |
|
📌 Commit a557e2f has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 30, 2018
Updated mozjs_sys to v0.51.3 <!-- Please describe your changes on the following line: --> Allows building servo for target `i686-linux-android`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21093 - [X] These changes do not require tests because deperndency update <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21102) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building servo for target
i686-linux-android../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is