Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check for GL object ownership (fixes #21133) #21240

Merged
merged 2 commits into from Jul 24, 2018
Merged

Properly check for GL object ownership (fixes #21133) #21240

merged 2 commits into from Jul 24, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Jul 24, 2018 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglprogram.rs, components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs and 5 more
  • @KiChjang: components/script/dom/webglprogram.rs, components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs and 5 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 24, 2018
@jdm
Copy link
Member

jdm commented Jul 24, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 3179ed5 has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey Jul 24, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 24, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 3179ed5 with merge 65df9cb...

bors-servo pushed a commit that referenced this pull request Jul 24, 2018
Auto merge of #21240 - servo:webgl, r=jdm
65df9cb 
Properly check for GL object ownership (fixes #21133)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21240)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 24, 2018
@CYBAI
Copy link
Member

CYBAI commented Jul 24, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt2...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css2

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 24, 2018
@jdm
Copy link
Member

jdm commented Jul 24, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt2...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 65df9cb to master...

@bors-servo bors-servo merged commit 3179ed5 into master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nox @highfive @jdm @bors-servo @CYBAI @asajeffrey