Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache which capabilities are enabled in the context (fixes #20534) #21246

Merged
merged 1 commit into from Jul 25, 2018
Merged

Cache which capabilities are enabled in the context (fixes #20534) #21246

merged 1 commit into from Jul 25, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Jul 25, 2018 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 25, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Jul 25, 2018

r? @avadacatavra

@highfive highfive assigned avadacatavra and unassigned mbrubeck Jul 25, 2018
emilio
emilio approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/script/dom/webglrenderingcontext.rs Outdated
@@ -2192,15 +2185,15 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3
// FIXME: https://github.com/servo/servo/issues/20534
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the FIXME?

@emilio
Copy link
Member

emilio commented Jul 25, 2018

Oh, I hadn't seen the comment above, and @nox asked me to review on IRC. Sorry for stealing the review :(

@nox
Copy link
Contributor Author

nox commented Jul 25, 2018

@bors-servo r=emilio

I fixed the FIXMEs.

@bors-servo
Copy link
Contributor

📌 Commit 5a9ad01 has been approved by emilio

@highfive highfive assigned emilio and unassigned avadacatavra Jul 25, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 25, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 5a9ad01 with merge 4c5a7ea...

bors-servo pushed a commit that referenced this pull request Jul 25, 2018
Auto merge of #21246 - servo:webgl, r=emilio
4c5a7ea 
Cache which capabilities are enabled in the context (fixes #20534)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21246)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 4c5a7ea to master...

@bors-servo bors-servo merged commit 5a9ad01 into master Jul 25, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 25, 2018
@emilio emilio deleted the webgl branch July 26, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nox @highfive @jdm @emilio @bors-servo @mbrubeck @avadacatavra