From 774138544e1eec3330309ad682fa05154a07ab8d Mon Sep 17 00:00:00 2001 From: Sven Gothel Date: Thu, 14 Oct 2010 21:26:43 +0200 Subject: [PATCH] JOGL: Reenable Applet/Webstart/RCP support for JOGL + AWT + X11 Changed GLProfile/NativeWindowFactory/.. initialization methodology: GLProfile: public static synchronized void initSingleton(final boolean firstUIActionOnProcess); NativeWindowFactory: public static synchronized void initSingleton(final boolean firstUIActionOnProcess); +++ Introducing NativeWindow ToolkitLock, implementations are NullToolkitLock JAWTToolkitLock X11JAWTToolkitLock X11ToolkitLock AbstractGraphicsDevice provides generic global toolkit locking methods, implemented by the ToolkitLock interface. ToolkitLock's are aggregated in NativeWindow's DefaultGraphicsDevice to implement it's superclass lock()/unlock() methods. This enables a device specific locking strategy, ie on X11/AWT utilizing JAWT && X11 locking, and maybe none for others (NEWT). No locking is required for X11 / AWT, in case the above mentioned initialization happened as a 'firstUIActionOnProcess'. The ToolkitLock factory is currently a hardcoded part of NativeWindowFactory. We may have to allow 3rd party NativeWindow implementations to register custom ones. +++ com.jogamp.opengl.impl.GLDrawableImpl cleanup: Dealing with all locking code, providing all public methods. Exceptions are commented. Specializations x11/windows/.. only contains platform code. Pulled down access qualifiers if possible public -> protected. com.jogamp.nativewindow.impl.x11.X11Util Wrapping all X11Lib method with the new locking code. com.jogamp.nativewindow.impl.jawt.JAWTUtil Utilize global SunToolkit.awtLock() is available, the fallback to global JAWT.lock(). The latter just invokes the first. javax.media.nativewindow.awt.AWTGraphicsDevice setHandle(long handle) -> setSubType(String type, long handle) which also resets the ToolkitLock respecting the new type. This ensures correct locking after the sub type has been determined, ie AWT using an X11 peer. +++ Misc Changes done on the way .. GLCanvas: Fixed inversed this.drawableHelper.isExternalAnimatorAnimating() condition, which disabled normal repaint. GLJPanel: Removed drawableHelper.isExternalAnimatorAnimating() condition, which disabled painting, since the animation thread just updates the source image. NEWT WindowImpl: When reparenting back to parent and 'refit' child if it's size exceeds it's parent. More 'Fix: Memory consumption' commit 6ced17f0325d5719e992b246ffd156e5b39694b4. NEWTEvent: Removed code to evaluate the 'system event' attribute, need to find a better approach. --- doc/Implementation/runtime-properties.txt | 39 +- make/build-junit.xml | 11 +- .../nativewindow/x11-CustomJavaCode.java | 3 - make/scripts/java-run-all.sh | 6 +- make/scripts/java-win64-dbg.bat | 4 +- make/scripts/make.jogl.all.linux-x86_64.sh | 1 + make/scripts/tests.bat | 23 +- make/scripts/tests.sh | 12 +- .../com/jogamp/opengl/impl/GLContextImpl.java | 4 +- .../opengl/impl/GLDrawableFactoryImpl.java | 98 +++-- .../jogamp/opengl/impl/GLDrawableImpl.java | 44 +- .../com/jogamp/opengl/impl/GLPbufferImpl.java | 6 +- .../jogamp/opengl/impl/GLWorkerThread.java | 2 +- .../com/jogamp/opengl/impl/awt/AWTUtil.java | 5 - .../com/jogamp/opengl/impl/awt/Java2D.java | 10 +- .../opengl/impl/egl/EGLDrawableFactory.java | 10 +- .../egl/EGLGraphicsConfigurationFactory.java | 7 +- .../macosx/cgl/MacOSXCGLDrawableFactory.java | 12 +- ...MacOSXCGLGraphicsConfigurationFactory.java | 5 +- .../macosx/cgl/MacOSXPbufferCGLDrawable.java | 6 +- ...OSXAWTCGLGraphicsConfigurationFactory.java | 5 +- .../windows/wgl/WindowsDummyWGLDrawable.java | 2 +- .../wgl/WindowsOffscreenWGLDrawable.java | 7 +- .../wgl/WindowsPbufferWGLDrawable.java | 4 +- .../impl/windows/wgl/WindowsWGLContext.java | 2 +- .../wgl/WindowsWGLDrawableFactory.java | 15 +- ...indowsWGLGraphicsConfigurationFactory.java | 15 +- ...owsAWTWGLGraphicsConfigurationFactory.java | 8 +- .../impl/x11/glx/X11DummyGLXDrawable.java | 6 +- .../opengl/impl/x11/glx/X11GLXContext.java | 6 +- .../impl/x11/glx/X11GLXDrawableFactory.java | 129 +++--- .../x11/glx/X11GLXGraphicsConfiguration.java | 2 +- .../X11GLXGraphicsConfigurationFactory.java | 16 +- .../impl/x11/glx/X11OffscreenGLXDrawable.java | 10 +- .../impl/x11/glx/X11PbufferGLXDrawable.java | 4 +- ...X11AWTGLXGraphicsConfigurationFactory.java | 8 +- .../com/jogamp/opengl/util/ImmModeSink.java | 10 +- .../javax/media/opengl/GLDrawableFactory.java | 4 +- .../javax/media/opengl/GLPipelineFactory.java | 4 +- .../classes/javax/media/opengl/GLProfile.java | 108 +++-- .../javax/media/opengl/awt/GLCanvas.java | 23 +- .../javax/media/opengl/awt/GLJPanel.java | 18 +- .../test/junit/jogl/acore/DumpVersion.java | 18 +- .../junit/jogl/acore/TestGLProfile01NEWT.java | 4 +- .../test/junit/jogl/awt/TestAWT01GLn.java | 5 +- .../jogl/awt/TestAWT02WindowClosing.java | 8 +- .../junit/jogl/awt/TestSwingAWT01GLn.java | 6 +- ...wingAWTRobotUsageBeforeJOGLInitBug411.java | 13 +- .../junit/jogl/demos/gl2/gears/Gears.java | 47 ++- .../jogl/demos/gl2/gears/TestGearsAWT.java | 5 +- .../jogl/demos/gl2/gears/TestGearsNEWT.java | 5 +- .../gl2/gears/TestGearsNewtAWTWrapper.java | 5 +- .../jogl/drawable/TestDrawable01NEWT.java | 5 +- ...stTransformFeedbackVeryingsBug407NEWT.java | 10 +- .../jogl/offscreen/TestOffscreen01NEWT.java | 5 +- .../junit/jogl/texture/TestTexture01AWT.java | 5 +- .../newt/TestDisplayLifecycle01NEWT.java | 53 +-- ...Bug.java => TestEventSourceNotAWTBug.java} | 4 +- .../junit/newt/TestFocus01SwingAWTRobot.java | 6 +- .../junit/newt/TestFocus02SwingAWTRobot.java | 2 +- .../test/junit/newt/TestGLWindows01NEWT.java | 5 +- .../newt/TestGLWindows02NEWTAnimated.java | 5 +- .../test/junit/newt/TestListenerCom01AWT.java | 5 +- .../test/junit/newt/TestWindows01NEWT.java | 1 + .../newt/parenting/TestParenting01NEWT.java | 5 +- .../newt/parenting/TestParenting01aAWT.java | 8 +- .../newt/parenting/TestParenting01bAWT.java | 5 +- .../newt/parenting/TestParenting01cAWT.java | 5 +- .../parenting/TestParenting01cSwingAWT.java | 5 +- .../newt/parenting/TestParenting02AWT.java | 5 +- .../newt/parenting/TestParenting02NEWT.java | 5 +- .../newt/parenting/TestParenting03AWT.java | 5 +- .../jogamp/test/junit/util/UITestCase.java | 1 + .../GraphicsConfigurationFactoryImpl.java | 5 +- .../impl/NativeWindowFactoryImpl.java | 8 +- .../nativewindow/impl/NullToolkitLock.java | 50 +++ .../nativewindow/impl/ProxySurface.java | 27 +- .../impl/jawt/JAWTToolkitLock.java | 54 +++ .../nativewindow/impl/jawt/JAWTUtil.java | 121 +++--- .../nativewindow/impl/jawt/JAWTWindow.java | 50 ++- .../impl/jawt/x11/X11JAWTToolkitLock.java | 60 +++ .../impl/jawt/x11/X11JAWTWindow.java | 112 +++-- .../impl/jawt/x11/X11SunJDKReflection.java | 6 +- .../x11/X11GraphicsConfigurationFactory.java | 12 +- .../nativewindow/impl/x11/X11ToolkitLock.java | 55 +++ .../jogamp/nativewindow/impl/x11/X11Util.java | 394 ++++++++++++++++-- .../nativewindow/AbstractGraphicsDevice.java | 9 + .../nativewindow/DefaultGraphicsDevice.java | 68 ++- .../GraphicsConfigurationFactory.java | 24 +- .../media/nativewindow/NativeSurface.java | 21 +- .../nativewindow/NativeWindowFactory.java | 243 +++++++++-- .../javax/media/nativewindow/ToolkitLock.java | 45 ++ .../nativewindow/awt/AWTGraphicsDevice.java | 18 +- .../nativewindow/x11/X11GraphicsDevice.java | 26 +- .../nativewindow/x11/X11GraphicsScreen.java | 9 +- src/nativewindow/native/x11/Xmisc.c | 70 ++-- .../classes/com/jogamp/newt/NewtFactory.java | 5 +- .../com/jogamp/newt/event/NEWTEvent.java | 6 +- .../com/jogamp/newt/impl/DisplayImpl.java | 10 +- .../com/jogamp/newt/impl/WindowImpl.java | 104 +++-- .../com/jogamp/newt/impl/awt/AWTCanvas.java | 4 +- .../com/jogamp/newt/impl/awt/AWTWindow.java | 2 +- .../jogamp/newt/impl/macosx/MacWindow.java | 9 +- .../newt/impl/windows/WindowsWindow.java | 10 +- .../com/jogamp/newt/impl/x11/X11Display.java | 2 +- .../com/jogamp/newt/impl/x11/X11Window.java | 4 +- .../com/jogamp/newt/opengl/GLWindow.java | 38 +- 107 files changed, 1827 insertions(+), 834 deletions(-) rename src/junit/com/jogamp/test/junit/newt/{TestEventSourceNotNEWTBug.java => TestEventSourceNotAWTBug.java} (96%) create mode 100644 src/nativewindow/classes/com/jogamp/nativewindow/impl/NullToolkitLock.java create mode 100644 src/nativewindow/classes/com/jogamp/nativewindow/impl/jawt/JAWTToolkitLock.java create mode 100644 src/nativewindow/classes/com/jogamp/nativewindow/impl/jawt/x11/X11JAWTToolkitLock.java create mode 100644 src/nativewindow/classes/com/jogamp/nativewindow/impl/x11/X11ToolkitLock.java create mode 100644 src/nativewindow/classes/javax/media/nativewindow/ToolkitLock.java diff --git a/doc/Implementation/runtime-properties.txt b/doc/Implementation/runtime-properties.txt index 8a2e3ef7ed..616029ed6a 100644 --- a/doc/Implementation/runtime-properties.txt +++ b/doc/Implementation/runtime-properties.txt @@ -1,4 +1,23 @@ -../doc/Implementation/properties/jogl.debug.all.txt +../doc/Implementation/runtime-properties-temp/gluegen-rt.debug.txt +---------------------------------------- + jogamp.debug.JNILibLoader + jogamp.debug.JVMUtil + jogamp.debug.Lock + jogamp.debug.ReflectionUtil + + + +../doc/Implementation/runtime-properties-temp/gluegen-rt.ipd.debug.txt +---------------------------------------- + jnlp.launcher.class + jogamp.common.utils.locks.Lock.timeout + jogamp.debug.Lock.TraceLock + sun.boot.library.path + sun.jnlp.applet.launcher + + + +../doc/Implementation/runtime-properties-temp/jogl.debug.all.txt ---------------------------------------- jogl.debug.Animator jogl.debug.BuildMipmap @@ -22,23 +41,26 @@ -../doc/Implementation/properties/jogl.ipd.debug.txt +../doc/Implementation/runtime-properties-temp/jogl.ipd.debug.txt ---------------------------------------- + jogl.1thread jogl.debug.ExtensionAvailabilityCache jogl.debug.GLDrawable.profiling jogl.debug.GLSLCode jogl.debug.GLSLState jogl.debug.TextRenderer jogl.glcontext.forcetracking + jogl.gldrawablefactory.class.name jogl.gljpanel.nohw jogl.gljpanel.noogl jogl.gljpanel.nosw + jogl.screenchange.action jogl.texture.nonpot jogl.texture.notexrect -../doc/Implementation/properties/nativewindow.debug.txt +../doc/Implementation/runtime-properties-temp/nativewindow.debug.txt ---------------------------------------- nativewindow.debug.DefaultCapabilitiesChooser nativewindow.debug.GraphicsConfiguration @@ -48,12 +70,14 @@ -../doc/Implementation/properties/nativewindow.ipd.debug.txt +../doc/Implementation/runtime-properties-temp/nativewindow.ipd.debug.txt ---------------------------------------- + java.awt.headless + nativewindow.ws.name -../doc/Implementation/properties/newt.debug.txt +../doc/Implementation/runtime-properties-temp/newt.debug.txt ---------------------------------------- newt.debug.Display newt.debug.EDT @@ -65,10 +89,13 @@ -../doc/Implementation/properties/newt.ipd.debug.txt +../doc/Implementation/runtime-properties-temp/newt.ipd.debug.txt ---------------------------------------- + newt.MainThread.force newt.test.EDTMainThread newt.test.Window.reparent.incompatible + newt.ws.sheight + newt.ws.swidth diff --git a/make/build-junit.xml b/make/build-junit.xml index 5a785a95d0..44a0a78660 100644 --- a/make/build-junit.xml +++ b/make/build-junit.xml @@ -99,9 +99,12 @@ - + + @@ -153,6 +156,9 @@ + @@ -174,11 +180,12 @@ - +