public
Fork of thoughtbot/shoulda
Description: Makes tests easy on the fingers and the eyes
Homepage: http://www.thoughtbot.com/projects/shoulda
Clone URL: git://github.com/showaltb/shoulda.git
commit  cefcfe1205f3636615e0562bba0ff60d3bf02922
tree    3ad87dc0f2392f87c23b39ce2f0b2af8d93fa1a8
parent  0de2794be2820ea22824aa6a6c3e4a940ab8f693
shoulda / CONTRIBUTION_GUIDELINES.rdoc
100644 13 lines (9 sloc) 1.548 kb

We’re using GitHub and Lighthouse, and we’ve been getting any combination of github pull requests, Lighthouse tickets, patches, emails, etc. We need to normalize this workflow to make sure we don’t miss any fixes.

  • Make sure you’re accessing the source from the official repository.
  • We prefer git branches over patches, but we can take either.
  • If you’re using git, please make a branch for each separate contribution. We can cherry pick your commits, but pulling from a branch is easier.
  • If you’re submitting patches, please cut each fix or feature into a separate patch.
  • There should be a Lighthouse ticket for any submission. If you’ve found a bug and want to fix it, open a new ticket at the same time.
  • We’ve got github/lighthouse integration going, so you can update tickets when you commit. This blog post explains the commit options pretty well.
  • Please don’t send pull requests Just update the lighthouse ticket with the url for your fix (or attach the patch) when it’s ready. The github pull requests pretty much get dropped on the floor until someone with commit rights notices them in the mailbox.
  • Contributions without tests won’t be accepted. The file /test/README explains the testing system pretty thoroughly.