Skip to content

Commit

Permalink
Fix signedness warnings in String.h
Browse files Browse the repository at this point in the history
  • Loading branch information
mniip committed Aug 18, 2019
1 parent e2787e0 commit f44d42d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/common/String.h
Expand Up @@ -509,7 +509,7 @@ class String : public std::basic_string<char32_t>
std::locale const &loc = std::locale::classic();
String value(*this);
for(value_type &ch : value)
if(ch <= std::numeric_limits<ByteString::value_type>::max())
if(ch <= static_cast<value_type>(std::numeric_limits<ByteString::value_type>::max()))
ch = std::tolower(static_cast<ByteString::value_type>(ch), loc);
return value;
}
Expand All @@ -519,7 +519,7 @@ class String : public std::basic_string<char32_t>
std::locale const &loc = std::locale::classic();
String value(*this);
for(value_type &ch : value)
if(ch <= std::numeric_limits<ByteString::value_type>::max())
if(ch <= static_cast<value_type>(std::numeric_limits<ByteString::value_type>::max()))
ch = std::toupper(static_cast<ByteString::value_type>(ch), loc);
return value;
}
Expand Down

0 comments on commit f44d42d

Please sign in to comment.