Renderer|SectorCluster|BspLeaf: SectorCluster routes BiasDigests to s…

…urfaces

Leaf-level granularity for routing change notifications is wrong as
this assumes there is at least one surface geometry at each leaf.
A binary space partition does not inherently mean a convex subspace
will exist at the leaf. The subspace geometry is only fully defined
(or inferred) at a higher level.

Previously leafs were given responsibility of routing bias lighting
change digests because no other component had direct access to all
of the internal surface geometries.

However, since the introduction of the half-edge data structure it
is now easily possible to navigate to any element in the map geometry
mesh from anywhere else (provided they are connected by at least one
edge, of course).

This means this routing logic can now be placed in SectorCluster so
that we can take advantage of the extra spatial knowledge.

Todo: SectorCluster should also be responsible for surface BiasIllum
generation and management. Presently an illumination point is needed
for every face => vertex interception in the half-edge data structure
despite that many will never be used. SectorCluster has the necessary
knowledge to avoid allocating illumination points for internal edges
with no possible surface (inherently zero-area and will remain so,
regardless of plane movement or map hack mappings).

doomsday/client/include/render/lightgrid.h

@@ -90,8 +90,8 @@ class LightGrid
      * @param point  3D point.
      *
      * @return  Evaluated color at the specified point.
-     * - [x, y, z] = RGB color with premultiplied luminance factor
-     * - [w]       = luminance factor (i.e., light level)
+     * - [x, y, z] = RGB color with premultiplied light intensity factor
+     * - [w]       = light intensity factor (i.e., light level)
      */
     Vector4f evaluate(Vector3d const &point);
 

doomsday/client/include/world/sectorcluster.h

@@ -39,6 +39,9 @@
 #include <QList>
 
 class BspLeaf;
+#ifdef __CLIENT__
+class BiasDigest;
+#endif
 
 /**
  * Adjacent BSP leafs in the sector (i.e., those which share one or more
@@ -230,6 +233,13 @@ class SectorCluster
      */
     AudioEnvironmentFactors const &reverb() const;
 
+    /**
+     * Apply bias lighting changes to @em all surfaces within the cluster.
+     *
+     * @param changes  Digest of lighting changes to be applied.
+     */
+    void applyBiasDigest(BiasDigest &changes);
+
     /**
      * Returns the unique identifier of the light source.
      */

doomsday/client/src/render/lightgrid.cpp

@@ -121,7 +121,7 @@ DENG2_PIMPL(LightGrid)
          * Construct a new light block using the source specified as the @em primary
          * illumination source for the block.
          *
-         * @param primarySource  Primary illumation. Use @c 0 to create a "null-block".
+         * @param primarySource  Primary illumination. Use @c 0 to create a "null-block".
          */
         LightBlock(IBlockLightSource *primarySource = 0)
             : bias(0), source(primarySource)

doomsday/client/src/world/bspleaf.cpp

@@ -474,13 +474,6 @@ void BspLeaf::updateBiasAfterGeometryMove(int group)
     }
 }
 
-static void applyBiasDigestToWallSections(HEdge *hedge, BiasDigest &changes)
-{
-    if(!hedge || !hedge->hasMapElement())
-        return;
-    hedge->mapElementAs<LineSideSegment>().applyBiasDigest(changes);
-}
-
 void BspLeaf::applyBiasDigest(BiasDigest &changes)
 {
     if(!hasPoly()) return;
@@ -490,25 +483,6 @@ void BspLeaf::applyBiasDigest(BiasDigest &changes)
     {
         it.value().biasTracker.applyChanges(changes);
     }
-
-    HEdge *base = poly().hedge();
-    HEdge *hedge = base;
-    do
-    {
-        applyBiasDigestToWallSections(hedge, changes);
-    } while((hedge = &hedge->next()) != base);
-
-    foreach(Mesh *mesh, extraMeshes())
-    foreach(HEdge *hedge, mesh->hedges())
-    {
-        applyBiasDigestToWallSections(hedge, changes);
-    }
-
-    foreach(Polyobj *polyobj, d->polyobjs)
-    foreach(HEdge *hedge, polyobj->mesh().hedges())
-    {
-        applyBiasDigestToWallSections(hedge, changes);
-    }
 }
 
 void BspLeaf::lightBiasPoly(int group, Vector3f const *posCoords, Vector4f *colorCoords)

doomsday/client/src/world/map.cpp

@@ -1277,9 +1277,9 @@ DENG2_OBSERVES(bsp::Partitioner, UnclosedSectorFound)
          * Apply changes to all surfaces:
          */
         bias.lastChangeOnFrame = R_FrameCount();
-        foreach(BspLeaf *bspLeaf, bspLeafs)
+        foreach(SectorCluster *cluster, clusters)
         {
-            bspLeaf->applyBiasDigest(allChanges);
+            cluster->applyBiasDigest(allChanges);
         }
     }
 

doomsday/client/src/world/sectorcluster.cpp

@@ -982,6 +982,40 @@ bool SectorCluster::hasSkyMaskedPlane() const
     return false;
 }
 
+static void applyBiasDigestToWallSections(HEdge *hedge, BiasDigest &changes)
+{
+    if(!hedge || !hedge->hasMapElement())
+        return;
+    hedge->mapElementAs<LineSideSegment>().applyBiasDigest(changes);
+}
+
+void SectorCluster::applyBiasDigest(BiasDigest &changes)
+{
+    foreach(BspLeaf *bspLeaf, d->bspLeafs)
+    {
+        bspLeaf->applyBiasDigest(changes);
+
+        HEdge *base = bspLeaf->poly().hedge();
+        HEdge *hedge = base;
+        do
+        {
+            applyBiasDigestToWallSections(hedge, changes);
+        } while((hedge = &hedge->next()) != base);
+
+        foreach(Mesh *mesh, bspLeaf->extraMeshes())
+        foreach(HEdge *hedge, mesh->hedges())
+        {
+            applyBiasDigestToWallSections(hedge, changes);
+        }
+
+        foreach(Polyobj *polyobj, bspLeaf->polyobjs())
+        foreach(HEdge *hedge, polyobj->mesh().hedges())
+        {
+            applyBiasDigestToWallSections(hedge, changes);
+        }
+    }
+}
+
 SectorCluster::LightId SectorCluster::lightSourceId() const
 {
     /// @todo Need unique cluster ids.