From 16280dbb3ed8bc9d98a07f2f5ffb8bff1850e551 Mon Sep 17 00:00:00 2001
From: skyjake <skyjake@users.sf.net>
Date: Thu, 21 Feb 2013 08:55:15 +0200
Subject: [PATCH] libshell|Refactor|AbstractLink: Made virtual connection and
 disconnection methods

---
 .../libshell/include/de/shell/abstractlink.h  |  8 +++----
 doomsday/libshell/src/abstractlink.cpp        | 22 +++++++++----------
 doomsday/libshell/src/link.cpp                |  4 ++--
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/doomsday/libshell/include/de/shell/abstractlink.h b/doomsday/libshell/include/de/shell/abstractlink.h
index 3b618c9b1d..27b3b373bc 100644
--- a/doomsday/libshell/include/de/shell/abstractlink.h
+++ b/doomsday/libshell/include/de/shell/abstractlink.h
@@ -57,26 +57,26 @@ class LIBSHELL_PUBLIC AbstractLink : public QObject, public Transmitter
      * @param domain   Domain/IP address of the server.
      * @param timeout  Keep trying until this much time has passed.
      */
-    void connect(String const &domain, TimeDelta const &timeout = 0);
+    virtual void connectDomain(String const &domain, TimeDelta const &timeout = 0);
 
     /**
      * Opens a connection to a server over the network.
      *
      * @param address  Address of the server.
      */
-    void connect(Address const &address);
+    virtual void connectHost(Address const &address);
 
     /**
      * Takes over an existing socket.
      *
      * @param openSocket  Socket. AbstractLink takes ownership.
      */
-    void takeOver(Socket *openSocket);
+    virtual void takeOver(Socket *openSocket);
 
     /**
      * Closes the connection.
      */
-    void disconnect();
+    virtual void disconnect();
 
     /**
      * Peer address of the link. The address may be a null address if the IP
diff --git a/doomsday/libshell/src/abstractlink.cpp b/doomsday/libshell/src/abstractlink.cpp
index 3645fd4164..fb8aa24ac4 100644
--- a/doomsday/libshell/src/abstractlink.cpp
+++ b/doomsday/libshell/src/abstractlink.cpp
@@ -51,16 +51,16 @@ AbstractLink::~AbstractLink()
     delete d;
 }
 
-void AbstractLink::connect(String const &domain, TimeDelta const &timeout)
+void AbstractLink::connectDomain(String const &domain, TimeDelta const &timeout)
 {
     disconnect();
 
     d->socket.reset(new Socket);
 
-    QObject::connect(d->socket.get(), SIGNAL(addressResolved()), this, SIGNAL(addressResolved()));
-    QObject::connect(d->socket.get(), SIGNAL(connected()), this, SLOT(socketConnected()));
-    QObject::connect(d->socket.get(), SIGNAL(disconnected()), this, SLOT(socketDisconnected()));
-    QObject::connect(d->socket.get(), SIGNAL(messagesReady()), this, SIGNAL(packetsReady()));
+    connect(d->socket.get(), SIGNAL(addressResolved()), this, SIGNAL(addressResolved()));
+    connect(d->socket.get(), SIGNAL(connected()), this, SLOT(socketConnected()));
+    connect(d->socket.get(), SIGNAL(disconnected()), this, SLOT(socketDisconnected()));
+    connect(d->socket.get(), SIGNAL(messagesReady()), this, SIGNAL(packetsReady()));
 
     // Fallback to default port.
     d->tryingToConnectToHost = domain;
@@ -72,16 +72,16 @@ void AbstractLink::connect(String const &domain, TimeDelta const &timeout)
     d->timeout = timeout;
 }
 
-void AbstractLink::connect(Address const &address)
+void AbstractLink::connectHost(Address const &address)
 {
     disconnect();
 
     d->peerAddress = address;
     d->socket.reset(new Socket);
 
-    QObject::connect(d->socket.get(), SIGNAL(connected()), this, SLOT(socketConnected()));
-    QObject::connect(d->socket.get(), SIGNAL(disconnected()), this, SLOT(socketDisconnected()));
-    QObject::connect(d->socket.get(), SIGNAL(messagesReady()), this, SIGNAL(packetsReady()));
+    connect(d->socket.get(), SIGNAL(connected()), this, SLOT(socketConnected()));
+    connect(d->socket.get(), SIGNAL(disconnected()), this, SLOT(socketDisconnected()));
+    connect(d->socket.get(), SIGNAL(messagesReady()), this, SIGNAL(packetsReady()));
 
     // Fallback to default port.
     if(!d->peerAddress.port()) d->peerAddress.setPort(13209);
@@ -101,8 +101,8 @@ void AbstractLink::takeOver(Socket *openSocket)
     d->socket.reset(openSocket);
 
     // Note: socketConnected() not used because the socket is already open.
-    QObject::connect(d->socket.get(), SIGNAL(disconnected()), this, SLOT(socketDisconnected()));
-    QObject::connect(d->socket.get(), SIGNAL(messagesReady()), this, SIGNAL(packetsReady()));
+    connect(d->socket.get(), SIGNAL(disconnected()), this, SLOT(socketDisconnected()));
+    connect(d->socket.get(), SIGNAL(messagesReady()), this, SIGNAL(packetsReady()));
 
     d->status = Connected;
     d->connectedAt = Time();
diff --git a/doomsday/libshell/src/link.cpp b/doomsday/libshell/src/link.cpp
index 8476c01b90..94ef5a248e 100644
--- a/doomsday/libshell/src/link.cpp
+++ b/doomsday/libshell/src/link.cpp
@@ -38,12 +38,12 @@ DENG2_PIMPL(Link)
 
 Link::Link(String const &domain, TimeDelta const &timeout) : d(new Instance(this))
 {
-    connect(domain, timeout);
+    connectDomain(domain, timeout);
 }
 
 Link::Link(Address const &address) : d(new Instance(this))
 {
-    connect(address);
+    connectHost(address);
 }
 
 Link::Link(Socket *openSocket) : d(new Instance(this))