UI|Client: Load game logos asynchronously

It may take a little while to load all the icons, and the UI shouldn’t be blocked in the meantime. This was particularly noticeable when reconfiguring the search folders.
skyjake · Nov 3, 2018 · 4921c65 · 4921c65
1 parent 8fcfb35
commit 4921c65
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/doomsday/apps/client/src/ui/home/gamepanelbuttonwidget.cpp b/doomsday/apps/client/src/ui/home/gamepanelbuttonwidget.cpp
@@ -33,6 +33,7 @@
 #include <doomsday/res/Bundles>
 
 #include <de/App>
+#include <de/Async>
 #include <de/CallbackAction>
 #include <de/ChildWidgetOrganizer>
 #include <de/FileSystem>
@@ -45,6 +46,7 @@ using namespace de;
 DENG_GUI_PIMPL(GamePanelButtonWidget)
 , DENG2_OBSERVES(Profiles::AbstractProfile, Change)
 , DENG2_OBSERVES(res::Bundles, Identify)
+, public AsyncScope
 {
     GameProfile &gameProfile;
     ui::FilteredDataT<SaveListData::SaveItem> savedItems;
@@ -240,7 +242,8 @@ DENG_GUI_PIMPL(GamePanelButtonWidget)
 
     void updateGameTitleImage()
     {
-        self().icon().setImage(IdTech1Image::makeGameLogo(game(), catalog));
+        *this += async([this]() { return IdTech1Image::makeGameLogo(game(), catalog); },
+                       [this](const Image &gameLogo) { self().icon().setImage(gameLogo); });
     }
 
     void profileChanged(Profiles::AbstractProfile &) override

diff --git a/doomsday/apps/client/src/ui/widgets/packageswidget.cpp b/doomsday/apps/client/src/ui/widgets/packageswidget.cpp
@@ -854,7 +854,6 @@ DENG_GUI_PIMPL(PackagesWidget)
         auto &w = widget.as<PackageListItemWidget>();
         w.setItem(item.as<PackageItem>());
         DENG2_ASSERT_IN_MAIN_THREAD();
-        DENG2_ASSERT(FS::get().busyLevel() == 0);
         w.updateContents();
     }
 };