Homepage|Build Repository|Fixed: Events not covered by the repository…

… should redirect to the index
skyjake · Mar 31, 2012 · cdd972c · cdd972c
1 parent 8812f9f
commit cdd972c
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/web/plugins/buildrepository/buildrepository.php b/web/plugins/buildrepository/buildrepository.php
@@ -779,8 +779,14 @@ public function InterpretRequest($request)
         {
             $this->initPackages();
 
-            $buildNumber = intval(substr($tokens[0], 5));
-            $FrontController->enqueueAction($this, array('build' => $buildNumber));
+            $buildId = intval(substr($tokens[0], 5));
+
+            // Is this a known event?
+            $build = $this->buildByUniqueId($buildId);
+            if(!$build instanceof BuildEvent)
+                $buildId = 0; // Show the index.
+
+            $FrontController->enqueueAction($this, array('build' => $buildId));
             return true; // Eat the request.
         }
 
@@ -819,15 +825,12 @@ private function outputBuildStreamNavigation(&$event)
     public function buildByUniqueId($uniqueId=0)
     {
         $uniqueId = intval($uniqueId);
-        $build = NULL;
         if($uniqueId > 0)
+        foreach($this->builds as &$build)
         {
-            foreach($this->builds as &$build)
-            {
-                if($uniqueId === $build->uniqueId()) break;
-            }
+            if($uniqueId === $build->uniqueId()) return $build;
         }
-        return $build;
+        return NULL;
     }
 
     private function outputEventList($maxEvents=10)