Fixed|libdeng2|ConstantRule: Only invalidate if value actually changes

A perf problem was caused by RuleRectangle updating the outputs in such a manner that caused ConstantRule to be always invalidated. Todo: Perhaps RuleRectangle could be better implemented with IndirectRules?
skyjake · Aug 19, 2013 · e8c68ad · e8c68ad
1 parent abbe8ed
commit e8c68ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/doomsday/libdeng2/include/de/widgets/operatorrule.h b/doomsday/libdeng2/include/de/widgets/operatorrule.h
@@ -57,8 +57,8 @@ class DENG2_PUBLIC OperatorRule : public Rule
         return *refless(new OperatorRule(Maximum, left, right));
     }
 
-    static Rule const &maximum(Rule const &left, Rule const *right) {
-        if(right) return *refless(new OperatorRule(Maximum, left, *right));
+    static Rule const &maximum(Rule const &left, Rule const *rightOrNull) {
+        if(rightOrNull) return *refless(new OperatorRule(Maximum, left, *rightOrNull));
         return left;
     }
 

diff --git a/doomsday/libdeng2/src/widgets/constantrule.cpp b/doomsday/libdeng2/src/widgets/constantrule.cpp
@@ -33,10 +33,13 @@ ConstantRule::ConstantRule(float constantValue)
 
 void ConstantRule::set(float newValue)
 {
-    _pendingValue = newValue;
+    if(!fequal(_pendingValue, newValue))
+    {
+        _pendingValue = newValue;
 
-    // Dependent values will need updating.
-    invalidate();
+        // Dependent values will need updating.
+        invalidate();
+    }
 }
 
 String ConstantRule::description() const