libdoomsday|libcore: Constructing profile duplicates

skyjake · Mar 27, 2016 · e937108 · e937108
1 parent 1f5513b
commit e937108
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 1 deletion.
diff --git a/doomsday/apps/libdoomsday/include/doomsday/gameprofiles.h b/doomsday/apps/libdoomsday/include/doomsday/gameprofiles.h
@@ -38,6 +38,7 @@ class LIBDOOMSDAY_PUBLIC GameProfiles : public de::Profiles
     {
     public:
         Profile(de::String const &name = "");
+        Profile(Profile const &other);
 
         void setGame(de::String const &id);
         void setPackages(de::StringList const &packagesInOrder);

diff --git a/doomsday/apps/libdoomsday/src/gameprofiles.cpp b/doomsday/apps/libdoomsday/src/gameprofiles.cpp
@@ -99,13 +99,27 @@ DENG2_PIMPL_NOREF(GameProfiles::Profile)
     String gameId;
     StringList packages;
     bool userCreated = false;
+
+    Instance() {}
+
+    Instance(Instance const &other)
+        : gameId     (other.gameId)
+        , packages   (other.packages)
+        , userCreated(other.userCreated)
+    {}
 };
 
-GameProfiles::Profile::Profile(String const &name) : d(new Instance)
+GameProfiles::Profile::Profile(String const &name)
+    : d(new Instance)
 {
     setName(name);
 }
 
+GameProfiles::Profile::Profile(Profile const &other)
+    : AbstractProfile(other)
+    , d(new Instance(*other.d))
+{}
+
 void GameProfiles::Profile::setGame(String const &id)
 {
     d->gameId = id;

diff --git a/doomsday/sdk/libcore/include/de/data/profiles.h b/doomsday/sdk/libcore/include/de/data/profiles.h
@@ -47,6 +47,7 @@ class DENG2_PUBLIC Profiles
     {
     public:
         AbstractProfile();
+        AbstractProfile(AbstractProfile const &profile);
 
         virtual ~AbstractProfile();
 

diff --git a/doomsday/sdk/libcore/src/data/profiles.cpp b/doomsday/sdk/libcore/src/data/profiles.cpp
@@ -346,6 +346,13 @@ Profiles::AbstractProfile::AbstractProfile()
     : d(new Instance(this))
 {}
 
+Profiles::AbstractProfile::AbstractProfile(AbstractProfile const &profile)
+    : d(new Instance(this))
+{
+    d->name     = profile.name();
+    d->readOnly = profile.isReadOnly();
+}
+
 Profiles::AbstractProfile::~AbstractProfile()
 {}