Skip to content

Commit

Permalink
Fixed|GL|OS X: Don’t fake EXT_compiled_vertex_array
Browse files Browse the repository at this point in the history
We should respect what the driver says is supported.
  • Loading branch information
skyjake committed Dec 12, 2013
1 parent f0bf647 commit ed37dfd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion doomsday/client/include/gl/sys_opengl.h
Expand Up @@ -47,7 +47,6 @@
#if defined(UNIX) && defined(MACOSX)
# define GL_GLEXT_PROTOTYPES
# if defined(MACOSX_NATIVESDK) || defined(MACOS_10_7)
# define GL_EXT_compiled_vertex_array 1
# include <OpenGL/gl.h>
# include <OpenGL/glext.h>
# include <OpenGL/OpenGL.h>
Expand Down
4 changes: 4 additions & 0 deletions doomsday/client/src/render/rend_model.cpp
Expand Up @@ -400,11 +400,15 @@ static void configureArrays(void *vertices, void *colors, int numCoords = 0,
}
}

#if GL_EXT_compiled_vertex_array
if(GL_state.features.elementArrays && lock > 0)
{
// 'lock' is the number of vertices to lock.
glLockArraysEXT(0, lock);

/// @todo Never unlocked? Maybe this is dead code? -jk

This comment has been minimized.

Copy link
@danij-deng

danij-deng Dec 12, 2013

Collaborator

Yeah I think so. I believe we disabled this method of buffering model geometry years ago, back when users were reporting issues with it and some video drivers (I don't recall which).

}
#endif

DENG_ASSERT(!Sys_GLCheckError());
}
Expand Down

0 comments on commit ed37dfd

Please sign in to comment.