Fixed|Widgets: Issues with the directory array widget

MessageDialog’s width rule was never released. DirectoryArrayWidget was using the wrong keys for Config.resource.recursedFolders and did not indicate that changes occurred after toggling “Subdirs”.
skyjake · Oct 28, 2018 · fcd13a7 · fcd13a7
1 parent 4cf017b
commit fcd13a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/doomsday/sdk/libappfw/src/dialogs/messagedialog.cpp b/doomsday/sdk/libappfw/src/dialogs/messagedialog.cpp
@@ -58,6 +58,11 @@ DENG_GUI_PIMPL(MessageDialog)
         updateLayout();
     }
 
+    ~Impl() override
+    {
+        releaseRef(layoutWidth);
+    }
+
     void updateLayout(LayoutBehavior behavior = ExcludeHidden)
     {
         ScrollAreaWidget &area = self().area();

diff --git a/doomsday/sdk/libappfw/src/widgets/directoryarraywidget.cpp b/doomsday/sdk/libappfw/src/widgets/directoryarraywidget.cpp
@@ -103,7 +103,7 @@ struct RecurseToggler
 
     TextValue key() const
     {
-        return {item->label()};
+        return {item->data().toString()};
     }
 
     void fetch()
@@ -117,6 +117,7 @@ struct RecurseToggler
     void toggleStateChanged(ToggleWidget &toggle) override
     {
         recursed().value().setElement(key(), new NumberValue(toggle.isActive()));
+        emit owner->arrayChanged();
     }
 
     void widgetBeingDeleted(Widget &) override