Shell: Immediately update log history when receiving entries

Things like autocompletions are better printed sooner rather than later for better UX.
skyjake · Mar 20, 2014 · fd6d31f · fd6d31f
1 parent 758c0f7
commit fd6d31f
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 1 deletion.
diff --git a/doomsday/tools/shell/shell-gui/src/linkwindow.cpp b/doomsday/tools/shell/shell-gui/src/linkwindow.cpp
@@ -90,6 +90,7 @@ DENG2_PIMPL(LinkWindow)
     {
         // Configure the log buffer.
         logBuffer.setMaxEntryCount(50); // buffered here rather than appBuffer
+        logBuffer.setAutoFlushInterval(0.1);
     }
 
     ~Instance()

diff --git a/doomsday/tools/shell/shell-gui/src/qtguiapp.cpp b/doomsday/tools/shell/shell-gui/src/qtguiapp.cpp
@@ -35,6 +35,8 @@ DENG2_PIMPL(QtGuiApp)
         LogBuffer::setAppBuffer(logBuffer);
         Clock::setAppClock(&clock);
         Animation::setClock(&clock);
+
+        logBuffer.setAutoFlushInterval(0.1);
     }
 
     ~Instance()

diff --git a/doomsday/tools/shell/shell-gui/src/qtrootwidget.cpp b/doomsday/tools/shell/shell-gui/src/qtrootwidget.cpp
@@ -29,7 +29,8 @@
 using namespace de;
 using namespace de::shell;
 
-const int BLINK_INTERVAL = 500; // ms
+static int const REFRESH_INTERVAL = 1000 / 30; // ms
+static int const BLINK_INTERVAL   = 500;       // ms
 
 #ifdef MACOSX
 #  define CONTROL_MOD   Qt::MetaModifier
@@ -94,6 +95,11 @@ QtRootWidget::QtRootWidget(QWidget *parent)
 {
     setFocusPolicy(Qt::StrongFocus);
 
+    // Continually check for need to update.
+    QTimer *refresh = new QTimer(this);
+    connect(refresh, SIGNAL(timeout()), this, SLOT(updateIfRequested()));
+    refresh->start(REFRESH_INTERVAL);
+
     // Blinking timers.
     d->blinkTimer = new QTimer(this);
     connect(d->blinkTimer, SIGNAL(timeout()), this, SLOT(blink()));
@@ -256,6 +262,14 @@ void QtRootWidget::paintEvent(QPaintEvent *)
     }
 }
 
+void QtRootWidget::updateIfRequested()
+{
+    if(d->root.drawWasRequested())
+    {
+        update();
+    }
+}
+
 void QtRootWidget::blink()
 {
     d->blinkVisible = !d->blinkVisible;

diff --git a/doomsday/tools/shell/shell-gui/src/qtrootwidget.h b/doomsday/tools/shell/shell-gui/src/qtrootwidget.h
@@ -56,6 +56,7 @@ class QtRootWidget : public QWidget
     void paintEvent(QPaintEvent *ev);
 
 protected slots:
+    void updateIfRequested();
     void blink();
     void cursorBlink();
 

diff --git a/doomsday/tools/shell/shell-text/src/cursesapp.cpp b/doomsday/tools/shell/shell-text/src/cursesapp.cpp
@@ -88,6 +88,7 @@ DENG2_PIMPL(CursesApp)
     Instance(Public &i) : Base(i), unicodeContinuation(0), rootWidget(0)
     {
         logBuffer.enableStandardOutput(false);
+        logBuffer.setAutoFlushInterval(0.1);
 
         de::LogBuffer::setAppBuffer(logBuffer);
         de::Animation::setClock(&clock);

diff --git a/doomsday/tools/shell/shell-text/src/shellapp.cpp b/doomsday/tools/shell/shell-text/src/shellapp.cpp
@@ -142,6 +142,7 @@ ShellApp::ShellApp(int &argc, char **argv)
     // Configure the log buffer.
     LogBuffer &buf = LogBuffer::appBuffer();
     buf.setMaxEntryCount(50); // buffered here rather than appBuffer
+    buf.enableFlushing();
     buf.addSink(d->log->logSink());
 
     QStringList args = arguments();