@@ -343,17 +343,20 @@ module ThoughtBot # :nodoc: # # Options: # * <tt>:through</tt> - association name for <tt>has_many :through</tt> + # * <tt>:dependent</tt> - tests that the association makes use of the dependent option. # # Example: # should_have_many :friends # should_have_many :enemies, :through => :friends + # should_have_many :enemies, :dependent => :destroy # def should_have_many(*associations) - through = get_options!(associations, :through) + through, dependent = get_options!(associations, :through, :dependent) klass = model_class associations.each do |association| name = "have many #{association}" name += " through #{through}" if through + name += " dependent => #{dependent}" if dependent should name do reflection = klass.reflect_on_association(association) assert reflection, "#{klass.name} does not have any relationship to #{association}" @@ -374,7 +377,9 @@ module ThoughtBot # :nodoc: else fk = reflection.primary_key_name end + associated_klass = (reflection.options[:class_name] || association.to_s.classify).constantize + assert_equal dependent, reflection.options[:dependent], "#{associated_klass.name} should have #{dependent.to_s} dependency" if dependent assert associated_klass.column_names.include?(fk.to_s), "#{associated_klass.name} does not have a #{fk} foreign key." end end lib/shoulda/active_record_helpers.rb @@ -1,5 +1,5 @@ class Tag < ActiveRecord::Base - has_many :taggings + has_many :taggings, :dependent => :destroy has_many :posts, :through => :taggings validates_length_of :name, :minimum => 2 test/rails_root/app/models/tag.rb @@ -3,7 +3,7 @@ require File.dirname(__FILE__) + '/../test_helper' class TagTest < Test::Unit::TestCase load_all_fixtures - should_have_many :taggings + should_have_many :taggings, :dependent => :destroy should_have_many :posts should_ensure_length_at_least :name, 2 test/unit/tag_test.rb 71e52d9c40638cdf8480f7a4d206aa99aab8a6db Chris O'Sullivan thechrisoshow@gmail.com http://github.com/snowblink/shoulda/commit/2995ef728d224bd8fc02c8a9542b14a22c47bfb5 2995ef728d224bd8fc02c8a9542b14a22c47bfb5 2008-05-23T07:49:32-07:00 2008-05-23T07:44:20-07:00 Added dependent option to should_have_many 13bea3d6875c45d4ee62b3ea1d9c04b5d979a989 Chris O'Sullivan thechrisoshow@gmail.com