t/007_error_log.t @@ -73,6 +73,7 @@ has 'scoreboard' => ( ); has 'prefix' => ( is => 'rw', isa => 'Str', default => '' ); +has 'error_length' => ( is => 'rw', isa => 'Int', default => 255 ); sub debug { my $self = shift; @@ -136,6 +137,7 @@ sub insert { eval { $self->_try_insert($job,$dbh); }; + $self->debug("insert failed: $@") if $@; next unless $job->jobid; lib/TheSchwartz/Moosified.pm @@ -75,13 +75,17 @@ sub as_hashref { sub add_failure { my $job = shift; - my ($msg) = @_; + my $msg = shift; + $msg = '' unless defined $msg; my $table_error = $job->handle->client->prefix . 'error'; + if (my $len = $job->handle->client->error_length) { + $msg = substr($msg,0,$len); + } my $sql = qq~INSERT INTO $table_error (error_time, jobid, message, funcid) VALUES (?, ?, ?, ?)~; my $dbh = $job->dbh; my $sth = $dbh->prepare($sql); - $sth->execute(time(), $job->jobid, $msg || '', $job->funcid); + $sth->execute(time(), $job->jobid, $msg, $job->funcid); # and let's lazily clean some errors while we're here. my $maxage = $TheSchwartz::Moosified::T_ERRORS_MAX_AGE || (86400*7); lib/TheSchwartz/Moosified/Job.pm @@ -42,7 +42,7 @@ CREATE TABLE PREFIX_note ( CREATE TABLE PREFIX_error ( error_time INTEGER NOT NULL, jobid BIGINT NOT NULL, - message VARCHAR(255) NOT NULL, + message TEXT NOT NULL, funcid INT NOT NULL DEFAULT 0 ); schema/Pg.sql b8c98170a248d63d253026f634db33718a8da204 Stash jeremy.stashewsky@socialtext.com http://github.com/socialtext/theschwartz-moosified/commit/e441ded80f26cf4c104ac483bb7f4804890388e6 e441ded80f26cf4c104ac483bb7f4804890388e6 2009-05-20T12:26:09-07:00 2009-05-20T12:26:09-07:00 Add error_length option for error message logging e59c241d78418539bd2960ed64cbfdd3e28ccf15 Stash jeremy.stashewsky@socialtext.com