@@ -1,4 +1,4 @@ A memcached-based throttle - do something after a limit has been -reached within a certain time. Currently working on the best -way to "do something" as well as how best to conform to Ruby -standards for how this project should work. You know, test cases, etc. +reached within a certain time period. + + README @@ -32,8 +32,7 @@ describe "a throttle" do end t.record_event sleep(2) - violated(@cache.inspect) - lambda { t.record_event }.should_not raise_error() + t.record_event #}.should_not raise_error() end end spec/over_time.rb @@ -75,4 +75,13 @@ describe "a throttle" do lambda { t.record_event }.should raise_error('bork') end + it "should fail gracefully when memcache fails" do + t = Throttle.create + def t.test_threshold(count) + raise 'bork' + end + @cache.simulate_error_on_next + lambda { t.record_event }.should_not raise_error() + end + end spec/throttle.rb @@ -68,8 +68,9 @@ class Throttle @@memcache.set(self.gen_throttle_key, self, Time.now.to_i + @buckets * @time_per_bucket) rescue MemCache::MemCacheError - return self #memcache not working, silently ignore + #memcache not working, silently ignore end + return self end def Throttle.retrieve(name) @@ -97,6 +98,8 @@ class Throttle @initial_time ||= Time.now.to_i end +protected + ########################################## # some functions to determine cache keys def Throttle.gen_throttle_key(name) @@ -154,7 +157,7 @@ class Throttle prev_buckets.reject!{|n| n < 0} #won't exist before 0 prev_buckets.map!{|n| gen_bucket_key(n)} #map to cache keys if !prev_buckets.empty? - prev_buckets = Array.new(@@memcache.get(*prev_buckets)) + prev_buckets = [*@@memcache.get(*prev_buckets)] end prev_buckets.map!{|n| n ||= 0} #fill w/ 0 if any are missing return prev_buckets throttle.rb @@ -11,11 +11,15 @@ class Throttle::Simple < Throttle end end - CACHE = MemCache.new 'localhost:11211' Throttle.set_memcache(CACHE) -t = Throttle::Simple.create(:name => 'baz2', :buckets => 10, :time_per_bucket => 1) -puts t.inspect -puts t.record_event -#10.times {t.record_event} +t = Throttle::Simple.create( + :name => 'example', + :buckets => 10, + :time_per_bucket => 6 + # throttle over 1min period, broken into 10 intervals +) +t.record_event +puts "All's well until the next line" +10.times {t.record_event} # -> raises exception tryit.rb c888eb4f4a8158eb8da7831447a630a719f6a6fb Luke Meyer sosiouxme@gmail.com http://github.com/sosiouxme/throttle/commit/bfed1e4a1d2c13743c4ee3d1295ee28356ba6757 bfed1e4a1d2c13743c4ee3d1295ee28356ba6757 2008-10-19T20:47:21-07:00 2008-10-19T20:47:21-07:00 fix tests, bug e0474db1767c911d33b9f5d1fdb8c89a5cab92a1 Luke Meyer sosiouxme@gmail.com