[ovirt] answer files: Filter out all password keys #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didib
force-pushed
the
filter-all-password-keys-in-answer-files
branch
2 times, most recently
from
f9b8ae7
to
42abb1d
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
@sandrobonazzola can you please review? Thanks. |
|
Sorry, this won't work - we have passwords which do not have 'password' in their key. Will fix later. |
didib
force-pushed
the
filter-all-password-keys-in-answer-files
branch
from
42abb1d
to
c445c39
Compare
|
This pull request introduces 1 alert when merging c445c39 into fe81417 - view on LGTM.com new alerts:
|
didib
force-pushed
the
filter-all-password-keys-in-answer-files
branch
from
c445c39
to
0b60273
Compare
Instead of hard-coding specific keys and having to maintain them over time, replace the values of all keys that have 'password' in their name. I think this covers all our current and hopefully future keys. It might add "false positives" - keys that are not passwords but have 'password' in their name - and I think that's a risk worth taking. Sadly, the engine admin password prompt's name is 'OVESETUP_CONFIG_ADMIN_SETUP', which does not include 'password', so has to be listed specifically. A partial list of keys added since the replaced code was written: - grafana-related stuff - keycloak-related stuff - otopi-style answer files Signed-off-by: Yedidyah Bar David <didi@redhat.com> Change-Id: I416c6e4078e7c3638493eb271d08d73a0c22b5ba
didib
force-pushed
the
filter-all-password-keys-in-answer-files
branch
from
0b60273
to
2701067
Compare
|
OK, this does work. Please review/merge. Thanks! |
TurboTurtle
approved these changes
May 31, 2022
pmoravec
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding specific keys and having to maintain them over
time, replace the values of all keys that have 'password' in their name.
I think this covers all our current and hopefully future keys. It might
add "false positives" - keys that are not passwords but have 'password'
in their name - and I think that's a risk worth taking.
A partial list of keys added since the replaced code was written:
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines