Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page context to error logging in rendering #2570

Closed
bep opened this issue Oct 13, 2016 · 2 comments
Closed

Add page context to error logging in rendering #2570

bep opened this issue Oct 13, 2016 · 2 comments
Labels
Enhancement Outdated
Milestone
v0.18

Comments

@bep
Copy link
Member

bep commented Oct 13, 2016

A follow up to the new DocumentName in RenderingContext, see 766c82a
@bep bep added this to the v0.18 milestone Oct 13, 2016
@choeppler
Copy link
Contributor

I've had a look at the rst2html rendering stuff and will put together a PR w/ improved error logging for that case...

@choeppler choeppler mentioned this issue Oct 17, 2016
Merged
choeppler added a commit to choeppler/hugo that referenced this issue Oct 18, 2016
@choeppler
Add page context to error logging in rendering
be377b1 
Add logging of the errors/warnings which rst2html outputs to its stderr
stream when rendering rst documents. Note that rst2html outputs warnings
and errors to stderr but it also adds them to the generated html. ->
hugo logs everything in stderr as error.

Add / complete adding page context (path to file being rendered) to
anything logged by getRstContent and getAsciidocContent.

See gohugoio#2570
bep pushed a commit that referenced this issue Oct 19, 2016
@choeppler @bep
Add page context to error logging in rendering
ddf2a34 
Add logging of the errors/warnings which rst2html outputs to its stderr
stream when rendering rst documents. Note that rst2html outputs warnings
and errors to stderr but it also adds them to the generated html. ->
hugo logs everything in stderr as error.

Add / complete adding page context (path to file being rendered) to
anything logged by getRstContent and getAsciidocContent.

See #2570
@bep bep closed this as completed Nov 29, 2016
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@choeppler @tychoish
Add page context to error logging in rendering
2061253 
Add logging of the errors/warnings which rst2html outputs to its stderr
stream when rendering rst documents. Note that rst2html outputs warnings
and errors to stderr but it also adds them to the generated html. ->
hugo logs everything in stderr as error.

Add / complete adding page context (path to file being rendered) to
anything logged by getRstContent and getAsciidocContent.

See gohugoio#2570
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.18
Development

No branches or pull requests
2 participants
@bep @choeppler