Skip to content

Commit

Permalink
Remove unused local variables. Fix failing form test.
Browse files Browse the repository at this point in the history
  • Loading branch information
Juriy Zaytsev committed Mar 22, 2009
1 parent fa15f21 commit 2c986d8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG
@@ -1,3 +1,5 @@
* Remove unused local variables from `Element.extend`. Fix one of the form tests to remove `_extendedByPrototype` by setting it to `undefined` rather than `false` (`_extendedByPrototype` being `false` does not force `Element.extend` to re-extend element). (T.J. Crowder, kangax)

* Make test for `escapeHTML`/`unescapeHTML` more strict. (Chrome 1.x escapes "<" and "&" with `innerHTML`, but not ">") (kangax)

* Remove another sniffing from one of DOM tests. Fixes last IE8 failure. (kangax)
Expand Down
2 changes: 1 addition & 1 deletion src/dom/dom.js
Expand Up @@ -1690,7 +1690,7 @@ Element.extend = (function() {
element.nodeType != 1 || element == window) return element;

var methods = Object.clone(Methods),
tagName = element.tagName.toUpperCase(), property, value;
tagName = element.tagName.toUpperCase();

// extend methods for specific tags
if (ByTag[tagName]) Object.extend(methods, ByTag[tagName]);
Expand Down
4 changes: 2 additions & 2 deletions test/unit/form_test.js
Expand Up @@ -291,8 +291,8 @@ new Test.Unit.Runner({

form = $('bigform');
var input = form['tf_text'], select = form['tf_selectOne'];
input._extendedByPrototype = select._extendedByPrototype = false;

input._extendedByPrototype = select._extendedByPrototype = void 0;
this.assert($(input).anInputMethod);
this.assert(!input.aSelectMethod);
this.assertEqual('input', input.anInputMethod());
Expand Down

0 comments on commit 2c986d8

Please sign in to comment.