Commit 3e2e8d48b58061a993d1c1323c50c13554027cde to sstephenson's prototype

3e2e8d4
all branches
- caja
- experimental
- integration
- layout
- master
- pdoc_windows_fix
- rewrite
- sprockets
all tags
- 1.6.0.3
- 1.6.1_rc1
- 1.6.1_rc2
- 1.6.1_rc3
comments

sstephenson / prototype

675

Description:	Prototype JavaScript framework edit
Homepage:	http://prototypejs.org/ edit
Public Clone URL:	git://github.com/sstephenson/prototype.git Give this clone URL to anyone. `git clone git://github.com/sstephenson/prototype.git`
Your Clone URL:	git@github.com:sstephenson/prototype.git Use this clone URL yourself. `git clone git@github.com:sstephenson/prototype.git`

Work around an issue with assigning a variable within a "return" statement in 
V8/Google Chrome. [#325 state:resolved]

Andrew Dupont (author)

Fri Oct 10 11:42:27 -0700 2008

commit 3e2e8d48b58061a993d1c1323c50c13554027cde
tree 2a42b826905958016de8bc05308c7669bbcb824c
parent 34ee2078f8c61272b69bc9166fd0bf7f94dde5fc

CHANGELOG
src/event.js

CHANGELOG

...
 
 
1
2
3

...
1
2
3
4
5

0
@@ -1,3 +1,5 @@
0
+* Work around an issue with assigning a variable within a "return" statement in V8/Google Chrome. (Chris Lear, Oleg K, Maikel Punie, Andrew Dupont)
0
+
0
 *1.6.0.3* (September 29, 2008)
0
 
0
 * Add support for the Chrome browser in jstest.rb. (Andrew Dupont)

src/event.js

0
@@ -160,7 +160,8 @@ Object.extend(Event, (function() {
0
   }
0
   
0
   function getCacheForID(id) {
0
-    return cache[id] = cache[id] || { };
0
+    cache[id] = cache[id] || { };
0
+    return cache[id];
0
   }
0
   
0
   function getWrappersForEventName(id, eventName) {

Comments

dperini Sat Oct 18 17:01:06 -0700 2008

Could this have been written:

return ( cache[id] = ( cache[id] || { } ) );

without causing that bug, or was it a different problem ?

kangax Sat Oct 18 21:02:18 -0700 2008

Diego, It’s fixed in Chromium now, afaik.